From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pythia.bakeyournoodle.com (pythia.bakeyournoodle.com [203.82.209.197]) by ozlabs.org (Postfix) with ESMTP id 74435DDDF0 for ; Tue, 5 Feb 2008 16:18:43 +1100 (EST) Date: Tue, 5 Feb 2008 16:16:48 +1100 To: Sripathi Kodi Subject: [PATCH] [POWERPC] Use a sensible default for clock_getres() in the vdso. Message-ID: <20080205051648.GX6887@bakeyournoodle.com> References: <200801271932.59823.sripathik@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <200801271932.59823.sripathik@in.ibm.com> From: tony@bakeyournoodle.com (Tony Breeds) Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org, john stultz List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Jan 27, 2008 at 07:32:59PM +0530, Sripathi Kodi wrote: > Hi Paul, > > On PPC, I see a disparity between clock_getres implementations in the > vdso and syscall. I am using a IBM Openpower hardware and 2.6.24 kernel > with CONFIG_HIGH_RES_TIMERS=y. > > clock_getres call for CLOCK_REALTIME returns 1 millisecond. However, > when I edit arch/powerpc/kernel/vdso*/gettimeofday.S to force it to use > sys_clock_getres, I get 1 nanosecond resolution. The code in vdso seems > to be returning some pre-defined (incorrect) variables. > > Could you please let me know the reason for this? Is it something that > should be fixed in vdso? Can you try the attached patch and see it if works for you? From: Tony Breeds Subject: [PATCH] [POWERPC] Use a sensible default for clock_getres() in the vdso. This ensures that the syscall and the (fast) vdso versions of clock_getres() will return the same resolution. Signed-off-by: Tony Breeds --- arch/powerpc/kernel/asm-offsets.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel/asm-offsets.c b/arch/powerpc/kernel/asm-offsets.c index ed083fe..e6e4928 100644 --- a/arch/powerpc/kernel/asm-offsets.c +++ b/arch/powerpc/kernel/asm-offsets.c @@ -22,6 +22,7 @@ #include #include #include +#include #ifdef CONFIG_PPC64 #include #include @@ -312,7 +313,7 @@ int main(void) DEFINE(CLOCK_REALTIME, CLOCK_REALTIME); DEFINE(CLOCK_MONOTONIC, CLOCK_MONOTONIC); DEFINE(NSEC_PER_SEC, NSEC_PER_SEC); - DEFINE(CLOCK_REALTIME_RES, TICK_NSEC); + DEFINE(CLOCK_REALTIME_RES, (KTIME_MONOTONIC_RES).tv64); #ifdef CONFIG_BUG DEFINE(BUG_ENTRY_SIZE, sizeof(struct bug_entry)); -- 1.5.4 Yours Tony linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/ Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!