* [PATCH] PPC440EP Interrupt Triggering and Level Settings
@ 2008-02-10 19:24 Wolfgang Ocker
2008-02-11 6:33 ` Stefan Roese
2008-02-15 15:12 ` Josh Boyer
0 siblings, 2 replies; 3+ messages in thread
From: Wolfgang Ocker @ 2008-02-10 19:24 UTC (permalink / raw)
To: jwboyer, mporter; +Cc: linuxppc-dev
From: Wolfgang Ocker <weo@reccoware.de>
Corrected IRQ triggering and level settings according to latest revision
of the 440EP User Manual (rev 1.24 nov 16, 2007).
The incorrect settings might cause a failure of the network if both
onchip ethernet ports are under heavy load.
Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
---
--- linux-2.6.24/arch/ppc/platforms/4xx/ibm440ep.c.irq-trig 2008-01-24 23:58:37.000000000 +0100
+++ linux-2.6.24/arch/ppc/platforms/4xx/ibm440ep.c 2008-02-10 19:43:32.000000000 +0100
@@ -172,11 +172,11 @@
/* Polarity and triggering settings for internal interrupt sources */
struct ppc4xx_uic_settings ppc4xx_core_uic_cfg[] __initdata = {
{ .polarity = 0xffbffe03,
- .triggering = 0xfffffe00,
+ .triggering = 0x00000000,
.ext_irq_mask = 0x000001fc, /* IRQ0 - IRQ6 */
},
- { .polarity = 0xffffc6ef,
- .triggering = 0xffffc7ff,
+ { .polarity = 0xffffc6af,
+ .triggering = 0x06000140,
.ext_irq_mask = 0x00003800, /* IRQ7 - IRQ9 */
},
};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PPC440EP Interrupt Triggering and Level Settings
2008-02-10 19:24 [PATCH] PPC440EP Interrupt Triggering and Level Settings Wolfgang Ocker
@ 2008-02-11 6:33 ` Stefan Roese
2008-02-15 15:12 ` Josh Boyer
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2008-02-11 6:33 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Wolfgang Ocker
On Sunday 10 February 2008, Wolfgang Ocker wrote:
> From: Wolfgang Ocker <weo@reccoware.de>
>
> Corrected IRQ triggering and level settings according to latest revision
> of the 440EP User Manual (rev 1.24 nov 16, 2007).
>
> The incorrect settings might cause a failure of the network if both
> onchip ethernet ports are under heavy load.
>
> Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
Thanks, looks good.
Acked-by: Stefan Roese <sr@denx.de>
Best regards,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PPC440EP Interrupt Triggering and Level Settings
2008-02-10 19:24 [PATCH] PPC440EP Interrupt Triggering and Level Settings Wolfgang Ocker
2008-02-11 6:33 ` Stefan Roese
@ 2008-02-15 15:12 ` Josh Boyer
1 sibling, 0 replies; 3+ messages in thread
From: Josh Boyer @ 2008-02-15 15:12 UTC (permalink / raw)
To: Wolfgang Ocker; +Cc: linuxppc-dev
On Sun, 10 Feb 2008 20:24:02 +0100
Wolfgang Ocker <weo@reccoware.de> wrote:
> From: Wolfgang Ocker <weo@reccoware.de>
>
> Corrected IRQ triggering and level settings according to latest revision
> of the 440EP User Manual (rev 1.24 nov 16, 2007).
>
> The incorrect settings might cause a failure of the network if both
> onchip ethernet ports are under heavy load.
>
> Signed-off-by: Wolfgang Ocker <weo@reccoware.de>
Your patch is word-wrapped. I've gone ahead and fixed that up, but you
might want to figure that out for future patches.
josh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-15 15:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-10 19:24 [PATCH] PPC440EP Interrupt Triggering and Level Settings Wolfgang Ocker
2008-02-11 6:33 ` Stefan Roese
2008-02-15 15:12 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).