From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from pasmtpA.tele.dk (pasmtpa.tele.dk [80.160.77.114]) by ozlabs.org (Postfix) with ESMTP id EF489DDEBA for ; Tue, 12 Feb 2008 03:02:06 +1100 (EST) Date: Mon, 11 Feb 2008 17:02:11 +0100 From: Sam Ravnborg To: Jan-Bernd Themann Subject: Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier Message-ID: <20080211160211.GA22139@uranus.ravnborg.org> References: <200802111657.07534.ossthema@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <200802111657.07534.ossthema@de.ibm.com> Cc: "Themann, Jan-Bernd" , netdev , Dave Hansen , linux-kernel , Thomas Klein , linux-ppc , Christoph Raisch , Greg KH List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Feb 11, 2008 at 04:57:06PM +0100, Jan-Bernd Themann wrote: > Drivers like eHEA need memory notifiers in order to > update their internal DMA memory map when memory is added > to or removed from the system. Can you please add proper kernel-doc formatted comments when you export a symbol so others can get a clue what the exported function is supposed to do. Sam