From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Dave Jiang <djiang@mvista.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: Marvell 64x60 EDAC platform devices setup
Date: Tue, 12 Feb 2008 10:51:13 +1100 [thread overview]
Message-ID: <20080212105113.553659b0.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20080211225023.GA15541@blade.az.mvista.com>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
Hi Dave,
On Mon, 11 Feb 2008 15:50:23 -0700 Dave Jiang <djiang@mvista.com> wrote:
>
> +static int __init mv64x60_edac_pdev_init(struct device_node *np,
> + int id,
> + int num_addr,
> + char *pdev_name)
The pdev_name is just passed to platform_device_register_simple() which
take a "const char *", so make pdev_name consta as well, please.
> +static int __init mv64x60_pci_fixup(struct device_node *np)
> +{
> + struct resource res;
> + void __iomem *pci_serr;
> + int ret;
> +
> + ret = of_address_to_resource(np, 1, &res);
> + if (ret)
> + return ret;
> +
> + pci_serr = ioremap(res.start, res.end - res.start + 1);
Why not use of_iomap(np, 1), then you don't need res.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-02-11 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 22:50 [PATCH] powerpc: Marvell 64x60 EDAC platform devices setup Dave Jiang
2008-02-11 23:51 ` Stephen Rothwell [this message]
2008-02-13 0:11 ` [PATCH rev2] " Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080212105113.553659b0.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=djiang@mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).