From: David Miller <davem@davemloft.net>
To: galak@kernel.crashing.org
Cc: sparclinux@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base
Date: Wed, 13 Feb 2008 14:33:59 -0800 (PST) [thread overview]
Message-ID: <20080213.143359.258873954.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0802130719330.14428@blarg.am.freescale.net>
From: Kumar Gala <galak@kernel.crashing.org>
Date: Wed, 13 Feb 2008 07:37:27 -0600 (CST)
> If we add to an empty lmb region with a non-zero base we will not coalesce
> the number of regions done to one. This causes problems on ppc32 for the
> memory region as its assumed to only have one region.
>
> We can fix this be easily specially casing the initial add to just replace
> the dummy region.
>
> ---
>
> Posting this since Dave's looking a pulling the lmb code out into lib/ and
> sharing it between powerpc and sparc.
>
> (this is my git tree git.kernel.org:/pub/scm/linux/kernel/git/galak/powerpc.git)
I noticed this issue when I use lmb on sparc64 and I intended to bring
it up eventually. Thanks for fixing it!
prev parent reply other threads:[~2008-02-13 22:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 13:37 [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base Kumar Gala
2008-02-13 14:20 ` Jon Loeliger
2008-02-13 15:37 ` Kumar Gala
2008-02-13 22:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213.143359.258873954.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).