From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: linux-pci@atrey.karlin.mff.cuni.cz
Cc: Greg KH <greg@kroah.com>,
paulus@samba.org, anton@samba.org, Martin Mares <mj@ucw.cz>,
linuxppc-dev@ozlabs.org
Subject: Re: /proc/bus/pci and domains
Date: Thu, 14 Feb 2008 10:39:11 -0800 [thread overview]
Message-ID: <200802141039.12045.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <mj+md-20080214.093558.3352.nikam@ucw.cz>
On Thursday, February 14, 2008 1:40 am Martin Mares wrote:
> Hi Greg!
>
> > I have no idea, it sounds like a PPC specific thing, not anything the
> > PCI core does, right? So I'll add the ppc list to the cc: and ask if
> > anyone there has any ideas?
>
> Unfortunately, this is not PPC specific at all -- proc_attach_device()
> calls pci_proc_domain(bus), which is an arch-specific hook turning on
> the weird behavior I described. This hook can return non-zero even on
> x86 if there are buses outside domain 0.
>
> I think that the hook itself is correct, it only should trigger more
> consistent behavior of the generic code :)
>
> Would it be acceptable for the PPC folks to modify the code to add
> domain numbers to the device numbers in /proc/bus/pci/devices in the
> same format as the bus directories already have?
>
> If so, I will cook up a patch.
I've run into this too, on machines with many domains. It's unfortunate that
there's no way to preserve compatibility, but I agree that the brokenness may
as well be consistent.
Jesse
next prev parent reply other threads:[~2008-02-14 18:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mj+md-20080213.154522.9237.albireo@ucw.cz>
2008-02-14 4:43 ` /proc/bus/pci and domains Greg KH
2008-02-14 9:40 ` Martin Mares
2008-02-14 18:39 ` Jesse Barnes [this message]
2008-02-14 21:43 ` David Miller
2008-02-14 21:45 ` Matthew Wilcox
2008-02-14 21:46 ` Martin Mares
2008-02-14 21:45 ` Martin Mares
2008-02-14 22:17 ` David Miller
2008-02-14 22:21 ` Martin Mares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802141039.12045.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=anton@samba.org \
--cc=greg@kroah.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=mj@ucw.cz \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).