From: "Stephen Neuendorffer" <stephen.neuendorffer@xilinx.com>
To: "Pavel Kiryukhin" <pkiryukhin@ru.mvista.com>, <linuxppc-dev@ozlabs.org>
Subject: RE: [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift.
Date: Thu, 14 Feb 2008 10:55:31 -0800 [thread overview]
Message-ID: <20080214185534.81F625F808D@mail186-dub.bigfish.com> (raw)
In-Reply-To: <47B35ED8.7020404@ru.mvista.com>
> --- a/arch/powerpc/kernel/legacy_serial.c
> +++ b/arch/powerpc/kernel/legacy_serial.c
> + /* get regshift if present*/
> + regshift =3D get_property(np, "reg-shift", NULL);
of_get_property, presumably?
--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
> + regshift =3D get_property(np, "reg-shift", NULL);
ditto...
Otherwise,=20
Acked-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Also, can you post a patch to the Xilinx portion of
booting-without-of.txt that has the device tree entries necessary to get
the uart to work? (Since I happened to be tracking down what I assume
is the same issue when you posted the patch!)
Steve
next prev parent reply other threads:[~2008-02-14 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:19 [PATCH] [POWERPC] Enable correct operation of serial ports with nonzero regshift Pavel Kiryukhin
2008-02-14 3:56 ` Kumar Gala
2008-02-14 9:10 ` Pavel Kiryukhin
2008-02-14 14:28 ` Kumar Gala
2008-02-14 18:55 ` Stephen Neuendorffer [this message]
2008-02-14 23:27 ` [PATCH] [POWERPC] Enable correct operation of serial ports withnonzero regshift Stephen Rothwell
2008-02-14 23:33 ` Stephen Neuendorffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080214185534.81F625F808D@mail186-dub.bigfish.com \
--to=stephen.neuendorffer@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=pkiryukhin@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).