* [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.
@ 2008-02-15 21:08 Scott Wood
2008-02-15 21:47 ` Rune Torgersen
2008-02-20 16:50 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Scott Wood @ 2008-02-15 21:08 UTC (permalink / raw)
To: jgarzik; +Cc: netdev, linuxppc-dev
The lock acquisition in fs_ioctl() does not appear to actually be necessary,
and thus is simply removed.
Signed-off-by: Scott Wood <scottwood@freescale.com>
---
This fixes the following bug:
http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html
drivers/net/fs_enet/fs_enet-main.c | 7 +------
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c
index 42d94ed..af869cf 100644
--- a/drivers/net/fs_enet/fs_enet-main.c
+++ b/drivers/net/fs_enet/fs_enet-main.c
@@ -946,16 +946,11 @@ static int fs_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{
struct fs_enet_private *fep = netdev_priv(dev);
struct mii_ioctl_data *mii = (struct mii_ioctl_data *)&rq->ifr_data;
- unsigned long flags;
- int rc;
if (!netif_running(dev))
return -EINVAL;
- spin_lock_irqsave(&fep->lock, flags);
- rc = phy_mii_ioctl(fep->phydev, mii, cmd);
- spin_unlock_irqrestore(&fep->lock, flags);
- return rc;
+ return phy_mii_ioctl(fep->phydev, mii, cmd);
}
extern int fs_mii_connect(struct net_device *dev);
--
1.5.3.8
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.
2008-02-15 21:08 [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context Scott Wood
@ 2008-02-15 21:47 ` Rune Torgersen
2008-02-20 16:50 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Rune Torgersen @ 2008-02-15 21:47 UTC (permalink / raw)
To: Scott Wood, jgarzik; +Cc: netdev, linuxppc-dev
Scott Wood wrote:
> The lock acquisition in fs_ioctl() does not appear to actually be
> necessary, and thus is simply removed.
>=20
> Signed-off-by: Scott Wood <scottwood@freescale.com> ---
> This fixes the following bug:
> http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html
>=20
> drivers/net/fs_enet/fs_enet-main.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>=20
> diff --git a/drivers/net/fs_enet/fs_enet-main.c
> b/drivers/net/fs_enet/fs_enet-main.c
> index 42d94ed..af869cf 100644
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -946,16 +946,11 @@ static int fs_ioctl(struct net_device
> *dev, struct ifreq *rq, int cmd)
> {
> struct fs_enet_private *fep =3D netdev_priv(dev);
> struct mii_ioctl_data *mii =3D (struct mii_ioctl_data
*)&rq->ifr_data;
> - unsigned long flags;
> - int rc;
>=20
> if (!netif_running(dev))
> return -EINVAL;
>=20
> - spin_lock_irqsave(&fep->lock, flags);
> - rc =3D phy_mii_ioctl(fep->phydev, mii, cmd);
> - spin_unlock_irqrestore(&fep->lock, flags);
> - return rc;
> + return phy_mii_ioctl(fep->phydev, mii, cmd);
> }
>=20
> extern int fs_mii_connect(struct net_device *dev);
Acked-by: Rune Torgersen <runet@innovsys.com>
Tested it and it does indeed take care of the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context.
2008-02-15 21:08 [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context Scott Wood
2008-02-15 21:47 ` Rune Torgersen
@ 2008-02-20 16:50 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-02-20 16:50 UTC (permalink / raw)
To: Scott Wood; +Cc: netdev, linuxppc-dev
Scott Wood wrote:
> The lock acquisition in fs_ioctl() does not appear to actually be necessary,
> and thus is simply removed.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
> This fixes the following bug:
> http://ozlabs.org/pipermail/linuxppc-dev/2008-February/051564.html
>
> drivers/net/fs_enet/fs_enet-main.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-02-20 16:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-15 21:08 [PATCH] fs_enet: Don't call phy_mii_ioctl() in atomic context Scott Wood
2008-02-15 21:47 ` Rune Torgersen
2008-02-20 16:50 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).