From: Josh Boyer <jwboyer@gmail.com>
To: Olof Johansson <olof@lixom.net>
Cc: LinuxPPC-dev <linuxppc-dev@ozlabs.org>,
Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: arch_initcall time
Date: Mon, 18 Feb 2008 12:49:09 -0600 [thread overview]
Message-ID: <20080218124909.52796859@weaponx> (raw)
In-Reply-To: <20080218184240.GA17898@lixom.net>
On Mon, 18 Feb 2008 12:42:40 -0600
Olof Johansson <olof@lixom.net> wrote:
> On Mon, Feb 18, 2008 at 11:32:14AM -0700, Grant Likely wrote:
> > On Feb 18, 2008 11:31 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> > > On Feb 18, 2008 11:28 AM, Sean MacLennan <smaclennan@pikatech.com> wrote:
> > > > I need to call i2c_register_board_info for the new i2c style ad7414
> > > > driver. This needs to be called at arch initcall time. Currently I just
> > > > do this:
> > > >
> > > > static int __init warp_arch_init(void)
> > > > {
> > > > i2c_register_board_info(0, warp_i2c_info, ARRAY_SIZE(warp_i2c_info));
> > > > return 0;
> > > > }
> > > > arch_initcall(warp_arch_init);
> > >
> > > Yes, this is the right thing to do, but use machine_arch_initcall()
> > > instead so that it doesn't get called if it is not your board.
> >
> > That being said, I believe there is infrastructure to handle the
> > creation of your i2c board info from the device tree. Your i2c board
> > info should not be hard coded.
>
> Jon Smirl's patches? Not yet, unfortunately. It didn't make .25, but
> maybe for .26.
>
> (I will need to do it specifically on my platform, like fsl_soc already
> does, as a stopgap until then).
That, and Sean is still working on getting the iic device-tree-compliant driver through as
well :)
josh
prev parent reply other threads:[~2008-02-18 18:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 18:28 arch_initcall time Sean MacLennan
2008-02-18 18:31 ` Grant Likely
2008-02-18 18:32 ` Grant Likely
2008-02-18 18:42 ` Olof Johansson
2008-02-18 18:49 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080218124909.52796859@weaponx \
--to=jwboyer@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).