linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org
Cc: Jean Delvare <khali@linux-fr.org>,
	i2c@lm-sensors.org, Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: [PATCH 2/2] i2c-ibm_iic driver
Date: Tue, 19 Feb 2008 09:59:40 +0100	[thread overview]
Message-ID: <200802190959.41253.sr@denx.de> (raw)
In-Reply-To: <20080219092321.1fed233d@hyperion.delvare>

On Tuesday 19 February 2008, Jean Delvare wrote:
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index b61f56b..44c0984 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -244,7 +244,6 @@ config I2C_PIIX4
> >
> >  config I2C_IBM_IIC
> >  	tristate "IBM PPC 4xx on-chip I2C interface"
> > -	depends on IBM_OCP
> >  	help
> >  	  Say Y here if you want to use IIC peripheral found on
> >  	  embedded IBM PPC 4xx based systems.
>
> With this Kconfig change, "make menuconfig" lets me select the
> i2c-ibm_iic driver on x86_64, but it fails to build horribly. I think
> that you want to restrict the build to PPC machines somehow, or at
> least make sure that either IBM_OCP or OF support is present.

How about this:

-	depends on IBM_OCP
+	depends on 4xx

Best regards,
Stefan

  reply	other threads:[~2008-02-19  9:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 17:05 [PATCH] i2c-ibm_iic driver Sean MacLennan
     [not found] ` <47A14E23.50807@pikatech.com>
     [not found]   ` <20080214094516.1b958ae4@hyperion.delvare>
2008-02-16  4:07     ` [PATCH 1/2] " Sean MacLennan
2008-02-16  8:20       ` Jean Delvare
2008-02-16  4:11     ` [PATCH 2/2] " Sean MacLennan
2008-02-16  9:31       ` Jean Delvare
2008-02-16 20:54         ` Sean MacLennan
2008-02-17 10:52           ` Jean Delvare
2008-02-19  1:42         ` Sean MacLennan
2008-02-19  8:23           ` Jean Delvare
2008-02-19  8:59             ` Stefan Roese [this message]
2008-02-19 22:23               ` Sean MacLennan
2008-02-19 22:55               ` Arnd Bergmann
2008-02-19 23:18                 ` Sean MacLennan
2008-02-19 23:41                   ` Stephen Rothwell
2008-02-19 23:54                     ` Arnd Bergmann
2008-02-20  6:57                 ` Jean Delvare
2008-02-19 21:58             ` Sean MacLennan
2008-02-20  7:20               ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802190959.41253.sr@denx.de \
    --to=sr@denx.de \
    --cc=i2c@lm-sensors.org \
    --cc=khali@linux-fr.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=smaclennan@pikatech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).