From: "Nikita V. Youshchenko" <yoush@debian.org>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc: don't create two devices for each cpm_uart device tree node
Date: Wed, 20 Feb 2008 02:32:33 +0300 [thread overview]
Message-ID: <200802200232.44486@blacky.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 1903 bytes --]
powerpc: don't create two devices for each cpm_uart device tree node
Code in arch/powerpc/sysdev/fsl_soc.c used to create two 'struct device'
objects for each cpm_uart device tree node - one "fsl-cpm-scc:uart"
in cpm_uart_of_init() and one "fsl-cpm-smc:uart" in cpm_smc_uart_of_init().
This patch adds additional test to those routines, such that cpm_uart_of_init()
only registers devices with model "SCC", and cpm_smc_uart_of_init() only
registers devices with model "SMC".
Signed-off-by: Nikita Youshchenko <yoush@debian.org>
diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index f1b8412..536f8c9 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -890,6 +890,10 @@ static int __init cpm_uart_of_init(void)
const int *id;
const char *model;
+ model = of_get_property(np, "model", NULL);
+ if (!model || strcmp(model, "SCC") != 0)
+ continue;
+
memset(r, 0, sizeof(r));
memset(&cpm_uart_data, 0, sizeof(cpm_uart_data));
@@ -917,7 +921,6 @@ static int __init cpm_uart_of_init(void)
id = of_get_property(np, "device-id", NULL);
cpm_uart_data.fs_no = *id;
- model = of_get_property(np, "model", NULL);
strcpy(cpm_uart_data.fs_type, model);
cpm_uart_data.uart_clk = ppc_proc_freq;
@@ -1175,6 +1178,10 @@ static int __init cpm_smc_uart_of_init(void)
const int *id;
const char *model;
+ model = of_get_property(np, "model", NULL);
+ if (!model || strcmp(model, "SMC") != 0)
+ continue;
+
memset(r, 0, sizeof(r));
memset(&cpm_uart_data, 0, sizeof(cpm_uart_data));
@@ -1200,7 +1207,6 @@ static int __init cpm_smc_uart_of_init(void)
goto err;
}
- model = of_get_property(np, "model", NULL);
strcpy(cpm_uart_data.fs_type, model);
id = of_get_property(np, "device-id", NULL);
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2008-02-19 23:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 23:32 Nikita V. Youshchenko [this message]
2008-02-20 16:40 ` [PATCH] powerpc: don't create two devices for each cpm_uart device tree node Scott Wood
2008-02-21 6:13 ` Nikita V. Youshchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802200232.44486@blacky.localdomain \
--to=yoush@debian.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).