From: David Brownell <david-b@pacbell.net>
To: Greg KH <greg@kroah.com>
Cc: dbrownell@users.sourceforge.net, linux-usb@vger.kernel.org,
linuxppc-dev@ozlabs.org, stern@rowland.harvard.edu
Subject: Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver
Date: Wed, 20 Feb 2008 10:07:01 -0800 [thread overview]
Message-ID: <200802201007.01907.david-b@pacbell.net> (raw)
In-Reply-To: <20080220170300.GB3453@kroah.com>
On Wednesday 20 February 2008, Greg KH wrote:
> > Greg> Can you move the files under the hcd/ subdir
>
> Oops, I ment "host/" not, "hcd/".
>
> > Sorry, I don't think that's a good idea as the hardware can do
> > peripheral as well, and as you can see in patch 4, a gadget driver is
> > on it's way.
>
> Ok, that's fine, why can't the gadget stuff go into the gadget/
> directory then also? As this device is a host controller, it makes
> sense to me to keep it in the host-controller subdirectory.
FWIW we did the same thing with drivers/usb/musb (for the Mentor
highspeed OTG core) ... the basic issue is that the host and
peripheral sides of the hardware aren't split like that. There
would be lots of code sharing (FIFO access, IRQ handling, DMA,
initialization, come quickly to mind) between HCD and gadget
sides. Enough that trying to create an artificial split between
those -- and let it coordinate properly in OTG modes -- seemed
like a waste of effort.
- Dave
next prev parent reply other threads:[~2008-02-20 18:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 15:09 [patch v7 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Peter Korsgaard
2008-02-19 15:09 ` [patch v7 1/4] USB: add Cypress c67x00 low level interface code Peter Korsgaard
2008-02-19 15:09 ` [patch v7 2/4] USB: add Cypress c67x00 OTG controller core driver Peter Korsgaard
2008-02-19 15:09 ` [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver Peter Korsgaard
2008-02-19 23:55 ` Greg KH
2008-02-20 9:01 ` Peter Korsgaard
2008-02-20 16:16 ` Greg KH
2008-02-20 16:57 ` Peter Korsgaard
2008-02-20 17:03 ` Greg KH
2008-02-20 18:07 ` David Brownell [this message]
2008-02-20 18:29 ` Greg KH
2008-02-20 19:25 ` Peter Korsgaard
2008-02-19 15:09 ` [patch v7 4/4] USB: add Cypress c67x00 OTG controller gadget driver Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802201007.01907.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).