From: Stefan Roese <sr@denx.de>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] 4xx: Fix Haleakala PCIe compatibility problem in dts
Date: Wed, 20 Feb 2008 14:16:53 +0100 [thread overview]
Message-ID: <200802201416.54004.sr@denx.de> (raw)
In-Reply-To: <20080220070119.27dc250d@zod.rchland.ibm.com>
On Wednesday 20 February 2008, Josh Boyer wrote:
> > Since the 4xx PCIe driver checks for 405ex compatibility, the
> > PCIe interface was not detected as it is currently defined as
> > "405exr" compatible. This patch changes it to "405ex".
> >
> > The 405EX and 405EXr are identical exept that the 2nd PCIe and the
> > 2nd EMAC interfaces are missing.
>
> Does ppc405ex_pciex_core_init need to grow some logic to detect 405ex
> from 405exr and return the correct number of ports then? It
> unconditionally returns 2 today.
Yes, this could be done. Right now it works because the 405EXr board
(Haleakala) only instantiates one PCIe device in the dts.
A simple solution would be to just do a PVR check. Would this be acceptable?
Best regards,
Stefan
next prev parent reply other threads:[~2008-02-20 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 10:45 [PATCH] [POWERPC] 4xx: Fix Haleakala PCIe compatibility problem in dts Stefan Roese
2008-02-20 13:01 ` Josh Boyer
2008-02-20 13:16 ` Stefan Roese [this message]
2008-02-20 18:08 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802201416.54004.sr@denx.de \
--to=sr@denx.de \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).