From: David Brownell <david-b@pacbell.net>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: dbrownell@users.sourceforge.net, greg@kroah.com,
linux-usb@vger.kernel.org, linuxppc-dev@ozlabs.org,
stern@rowland.harvard.edu
Subject: Re: [patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver
Date: Wed, 20 Feb 2008 19:06:35 -0800 [thread overview]
Message-ID: <200802201906.35830.david-b@pacbell.net> (raw)
In-Reply-To: <20080220091401.612406000@sunsite.dk>
On Wednesday 20 February 2008, Peter Korsgaard wrote:
> +ifeq ($(CONFIG_USB_DEBUG),y)
> + EXTRA_CFLAGS += -DDEBUG
> +endif
The canonical Sam Ravnborg comment is to replace that with:
+ccflags-$(CONFIG_USB_DEBUG) += -DDEBUG
It's a newish idiom, most easily applied to new code before
it merges ... :)
> +++ linux-2.6/drivers/usb/host/Kconfig
> @@ -261,3 +261,15 @@
> To compile this driver as a module, choose M here: the
> module will be called r8a66597-hcd.
>
> +config USB_C67X00_HCD
> + tristate "Cypress C67x00 HCD support"
> + depends on USB
And I realize that some of the drivers there have violated the
normal "alphabetical order" convention, so maybe one big
cleanup patch would be in order ... but still, I'd rather see
such new options added in the right place, rather than need
to see them fixed up later.
- Dave
next prev parent reply other threads:[~2008-02-21 3:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 9:07 [patch v8 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Peter Korsgaard
2008-02-20 9:07 ` [patch v8 1/4] USB: add Cypress c67x00 low level interface code Peter Korsgaard
2008-02-20 16:13 ` Greg KH
2008-02-20 16:59 ` Peter Korsgaard
2008-02-20 17:40 ` Greg KH
2008-02-20 9:07 ` [patch v8 2/4] USB: add Cypress c67x00 OTG controller core driver Peter Korsgaard
2008-02-20 9:07 ` [patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver Peter Korsgaard
2008-02-21 3:06 ` David Brownell [this message]
2008-02-21 7:53 ` Peter Korsgaard
2008-02-20 9:07 ` [patch v8 4/4] USB: add Cypress c67x00 OTG controller gadget driver Peter Korsgaard
2008-02-20 16:14 ` [patch v8 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support Greg KH
2008-02-20 17:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802201906.35830.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=greg@kroah.com \
--cc=jacmet@sunsite.dk \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).