From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [207.189.120.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.linux-foundation.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 460C3DDDF5 for ; Fri, 22 Feb 2008 18:37:59 +1100 (EST) Date: Thu, 21 Feb 2008 23:24:18 -0800 From: Andrew Morton To: Jens Axboe Subject: Re: [BUG] Linux 2.6.25-rc2 - Regression from 2.6.24-rc1-git1 softlockup while bootup on powerpc Message-Id: <20080221232418.b93db8d9.akpm@linux-foundation.org> In-Reply-To: <20080219083633.GN23197@kernel.dk> References: <47B67E5E.4010001@linux.vnet.ibm.com> <20080217192913.GO23197@kernel.dk> <20080219170432.9c04376f.kamezawa.hiroyu@jp.fujitsu.com> <20080219083633.GN23197@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Giani , Srivatsa Vaddagiri , Linux Kernel Mailing List , linuxppc-dev@ozlabs.org, Ingo Molnar , Kamalesh Babulal , Dhaval, KAMEZAWA Hiroyuki , Balbir Singh List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 19 Feb 2008 09:36:34 +0100 Jens Axboe wrote: > But I think the radix 'scan over entire tree' is a bit fragile. eek, it had better not be. Was this an error in the caller? Hope so. > This > patch adds a parallel hlist for ease of properly browsing the members, Even though io_contexts are fairly uncommon, adding more stuff to a data structure was a pretty sad alternative to fixing a bug in radix_tree_gang_lookup(), or to fixing a bug in a caller of it. IOW: what exactly went wrong here??