From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] AMCC Kilauea (405EX): Disable EMAC loopback mode
Date: Fri, 22 Feb 2008 14:36:21 -0600 [thread overview]
Message-ID: <20080222143621.0579729b@weaponx> (raw)
In-Reply-To: <1203669132-9385-1-git-send-email-sr@denx.de>
On Fri, 22 Feb 2008 09:32:12 +0100
Stefan Roese <sr@denx.de> wrote:
> 405EX(r) has SDR0_MFR[E0CS/E1CS] set after reset. This selects
> the internal loopback mode. Clear these bits so that both EMACs
> don't use loopback mode as default.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
> I'm not sure if this should be done here in the board platform code,
> or in the newemac driver or perhaps in some code common for 405EX.
>
> Any thoughts on this welcome.
Why isn't this done in U-Boot? Or is it done if the network interface
is used? I know I've tftp'd a kernel onto my 405EXr board, so I'm
slightly confused why this is needed in the kernel.
Aside from that, I'm OK with it living in the platform code for Kilauea
(an Haleakala by inheritance). Particularly given the fact that this
should be fixing in U-Boot for any further boards that use 405EX(r)...
right?
josh
next prev parent reply other threads:[~2008-02-22 20:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 8:32 [PATCH] [POWERPC] AMCC Kilauea (405EX): Disable EMAC loopback mode Stefan Roese
2008-02-22 20:36 ` Josh Boyer [this message]
2008-02-22 21:49 ` Stefan Roese
2008-02-22 21:27 ` Benjamin Herrenschmidt
2008-02-22 21:54 ` Stefan Roese
2008-04-21 23:46 ` Benjamin Herrenschmidt
2008-04-22 5:15 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222143621.0579729b@weaponx \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).