From: "Guido Günther" <agx@sigxcpu.org>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] Export pmu_* variables unconditionally
Date: Wed, 27 Feb 2008 15:16:27 +0100 [thread overview]
Message-ID: <20080227141627.GA10374@bogon.ms20.nix> (raw)
In-Reply-To: <20080227141452.GA10345@bogon.ms20.nix>
Otherwise without CONFIG_SUSPEND we have:
ERROR: "pmu_batteries" [drivers/macintosh/apm_emu.ko] undefined!
ERROR: "pmu_battery_count" [drivers/macintosh/apm_emu.ko] undefined!
ERROR: "pmu_power_flags" [drivers/macintosh/apm_emu.ko] undefined!
on PPC32. The variables aren't wrapped in '#if defined(CONFIG_SUSPEND)'
so we probably shouldn't wrap the exports either. Fixes compilation on
ppc32.
Signed-off-by: Guido Guenther <agx@sigxcpu.org>
---
drivers/macintosh/via-pmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c
index 296edcb..399fc7f 100644
--- a/drivers/macintosh/via-pmu.c
+++ b/drivers/macintosh/via-pmu.c
@@ -2528,7 +2528,7 @@ EXPORT_SYMBOL(pmu_wait_complete);
EXPORT_SYMBOL(pmu_suspend);
EXPORT_SYMBOL(pmu_resume);
EXPORT_SYMBOL(pmu_unlock);
-#if defined(CONFIG_SUSPEND) && defined(CONFIG_PPC32)
+#if defined(CONFIG_PPC32)
EXPORT_SYMBOL(pmu_enable_irled);
EXPORT_SYMBOL(pmu_battery_count);
EXPORT_SYMBOL(pmu_batteries);
--
1.5.4.2
next prev parent reply other threads:[~2008-02-27 14:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 14:14 [PATCH] Always define pmu_sys_suspended Guido Günther
2008-02-27 14:16 ` Guido Günther [this message]
2008-03-08 19:20 ` [PATCH] Export pmu_* variables unconditionally Guido Günther
2008-03-12 22:54 ` [PATCH] Always define pmu_sys_suspended Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227141627.GA10374@bogon.ms20.nix \
--to=agx@sigxcpu.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).