From: Martin Langer <martin-langer@gmx.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Fix for Freescale ppc cores: major revision detection
Date: Wed, 27 Feb 2008 21:40:38 +0100 [thread overview]
Message-ID: <20080227204038.GA3529@tuba> (raw)
In-Reply-To: <18371.60089.808367.553892@cargo.ozlabs.ibm.com>
On Tue, Feb 26, 2008 at 09:32:25PM +1100, Paul Mackerras wrote:
> Martin Langer writes:
>
> Care to resend this with a proper description and a Signed-off-by
> line?
Sure.
> > + switch (PVR_VER(pvr)) {
> > + case 0x8000: /* 7441/7450/7451, Vger */
> > + case 0x8001: /* 7445/7455, Apollo 6 */
> > + case 0x8002: /* 7447/7457, Apollo 7 */
> > + case 0x8003: /* 7447A, Apollo 7 PM */
> > + case 0x8004: /* 7448, Apollo 8 */
> > + case 0x800c: /* 7410, Nitro */
>
> BTW, these case labels are all indented one tab too far.
Ok. Now it's fixed.
The major revision number of some ppc cores by Freescale is placed in
the configuration field instead of the major revision field. The patch
corrects the behaviour for those 74xx cores.
Signed-off-by: Martin Langer <martin-langer@gmx.de>
--- setup-common.c.ORIGINAL 2008-02-08 22:22:56.000000000 +0100
+++ setup-common.c 2008-02-27 21:21:44.000000000 +0100
@@ -241,8 +241,21 @@
/* If we are a Freescale core do a simple check so
* we dont have to keep adding cases in the future */
if (PVR_VER(pvr) & 0x8000) {
- maj = PVR_MAJ(pvr);
- min = PVR_MIN(pvr);
+ switch (PVR_VER(pvr)) {
+ case 0x8000: /* 7441/7450/7451, Voyager */
+ case 0x8001: /* 7445/7455, Apollo 6 */
+ case 0x8002: /* 7447/7457, Apollo 7 */
+ case 0x8003: /* 7447A, Apollo 7 PM */
+ case 0x8004: /* 7448, Apollo 8 */
+ case 0x800c: /* 7410, Nitro */
+ maj = ((pvr >> 8) & 0xF);
+ min = PVR_MIN(pvr);
+ break;
+ default: /* e500/book-e */
+ maj = PVR_MAJ(pvr);
+ min = PVR_MIN(pvr);
+ break;
+ }
} else {
switch (PVR_VER(pvr)) {
case 0x0020: /* 403 family */
next prev parent reply other threads:[~2008-02-27 20:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 20:29 [PATCH] Fix for Freescale ppc cores: major revision detection Martin Langer
2008-02-26 10:32 ` Paul Mackerras
2008-02-27 20:40 ` Martin Langer [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-09 17:47 Martin Langer
2008-02-11 15:01 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227204038.GA3529@tuba \
--to=martin-langer@gmx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).