[PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[Laurent Pinchart]

[-- Attachment #1: Type: text/plain, Size: 1606 bytes --]

The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the 
fs_mii_bb_platform_info structure are left-overs from the move to the Phy
Abstraction Layer subsystem. They can be safely removed.

Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
---
 arch/powerpc/sysdev/fsl_soc.c |    4 ----
 include/linux/fs_enet_pd.h    |    4 ----
 2 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/arch/powerpc/sysdev/fsl_soc.c b/arch/powerpc/sysdev/fsl_soc.c
index 3ace747..cefc8b4 100644
--- a/arch/powerpc/sysdev/fsl_soc.c
+++ b/arch/powerpc/sysdev/fsl_soc.c
@@ -804,10 +804,6 @@ static int __init fs_enet_of_init(void)
 					mdio_bb_prop[1];
 				fs_enet_mdio_bb_data.mdc_dat.bit =
 					mdio_bb_prop[2];
-				fs_enet_mdio_bb_data.mdio_port =
-					mdio_bb_prop[3];
-				fs_enet_mdio_bb_data.mdc_port =
-					mdio_bb_prop[4];
 				fs_enet_mdio_bb_data.delay =
 					mdio_bb_prop[5];
 
diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h
index 9bc045b..decc4b5 100644
--- a/include/linux/fs_enet_pd.h
+++ b/include/linux/fs_enet_pd.h
@@ -103,10 +103,6 @@ struct fs_mii_bb_platform_info {
 	struct fs_mii_bit 	mdio_dir;
 	struct fs_mii_bit 	mdio_dat;
 	struct fs_mii_bit	mdc_dat;
-	int mdio_port;	/* port & bit for MDIO */
-	int mdio_bit;
-	int mdc_port;	/* port & bit for MDC  */
-	int mdc_bit;
 	int delay;	/* delay in us         */
 	int irq[32]; 	/* irqs per phy's */
 };
-- 
1.5.0

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussée de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[Laurent Pinchart]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On Friday 15 February 2008 14:27, Laurent Pinchart wrote:
> The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the
> fs_mii_bb_platform_info structure are left-overs from the move to the Phy
> Abstraction Layer subsystem. They can be safely removed.
>
> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
[snip]

Is there something wrong with the patch ?

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussée de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[Scott Wood]

On Thu, Feb 28, 2008 at 01:49:01PM +0100, Laurent Pinchart wrote:
> On Friday 15 February 2008 14:27, Laurent Pinchart wrote:
> > The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the
> > fs_mii_bb_platform_info structure are left-overs from the move to the Phy
> > Abstraction Layer subsystem. They can be safely removed.
> >
> > Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> [snip]
> 
> Is there something wrong with the patch ?

No, the patch looks OK.  However, note that non-PPC_CPM_NEW_BINDING code
should go away altogether soon.

-Scott

Re: [PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[Kumar Gala]

On Feb 28, 2008, at 12:50 PM, Scott Wood wrote:

> On Thu, Feb 28, 2008 at 01:49:01PM +0100, Laurent Pinchart wrote:
>> On Friday 15 February 2008 14:27, Laurent Pinchart wrote:
>>> The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the
>>> fs_mii_bb_platform_info structure are left-overs from the move to  
>>> the Phy
>>> Abstraction Layer subsystem. They can be safely removed.
>>>
>>> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
>> [snip]
>>
>> Is there something wrong with the patch ?
>
> No, the patch looks OK.  However, note that non-PPC_CPM_NEW_BINDING  
> code
> should go away altogether soon.

also any such patch should normally go via netdev as its to a network  
driver.

- k

[PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[Laurent Pinchart]

[-- Attachment #1: Type: text/plain, Size: 1070 bytes --]

The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the
fs_mii_bb_platform_info structure are left-overs from the move to the Phy
Abstraction Layer subsystem. They are not used anymore and can be safely
removed.

Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
---
 include/linux/fs_enet_pd.h    |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h
index 9bc045b..decc4b5 100644
--- a/include/linux/fs_enet_pd.h
+++ b/include/linux/fs_enet_pd.h
@@ -103,10 +103,6 @@ struct fs_mii_bb_platform_info {
 	struct fs_mii_bit 	mdio_dir;
 	struct fs_mii_bit 	mdio_dat;
 	struct fs_mii_bit	mdc_dat;
-	int mdio_port;	/* port & bit for MDIO */
-	int mdio_bit;
-	int mdc_port;	/* port & bit for MDC  */
-	int mdc_bit;
 	int delay;	/* delay in us         */
 	int irq[32]; 	/* irqs per phy's */
 };
-- 
1.5.0


-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] fs_enet: Remove unused fields in the fs_mii_bb_platform_info structure.

[Jeff Garzik]

Laurent Pinchart wrote:
> The mdio_port, mdio_bit, mdc_port and mdc_bit fields in the
> fs_mii_bb_platform_info structure are left-overs from the move to the Phy
> Abstraction Layer subsystem. They are not used anymore and can be safely
> removed.
> 
> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> ---
>  include/linux/fs_enet_pd.h    |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/include/linux/fs_enet_pd.h b/include/linux/fs_enet_pd.h
> index 9bc045b..decc4b5 100644
> --- a/include/linux/fs_enet_pd.h
> +++ b/include/linux/fs_enet_pd.h
> @@ -103,10 +103,6 @@ struct fs_mii_bb_platform_info {
>  	struct fs_mii_bit 	mdio_dir;
>  	struct fs_mii_bit 	mdio_dat;
>  	struct fs_mii_bit	mdc_dat;
> -	int mdio_port;	/* port & bit for MDIO */
> -	int mdio_bit;
> -	int mdc_port;	/* port & bit for MDC  */
> -	int mdc_bit;
>  	int delay;	/* delay in us         */
>  	int irq[32]; 	/* irqs per phy's */

applied