From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org, Grant Erickson <erick205@umn.edu>
Subject: Re: [PATCH] [POWERPC] 40X: Add Default Restart Machdep Method to 40X Platforms
Date: Sat, 1 Mar 2008 07:15:35 -0600 [thread overview]
Message-ID: <20080301071535.643a5d93@zod.rchland.ibm.com> (raw)
In-Reply-To: <200803011232.54392.sr@denx.de>
On Sat, 1 Mar 2008 12:32:54 +0100
Stefan Roese <sr@denx.de> wrote:
> On Saturday 23 February 2008, Grant Erickson wrote:
> > This patch restores the reset on restart functionality to 40x-based
> > platforms that was formerly provided--but not used in arch/powerpc--by
> > abort() in head_40x.S. This functionality is now provided by
> > ppc40x_reset_system(char *) in a fashion similar to that of the 44x-based
> > platforms.
> >
> > Compiled, linked and tested against the AMCC Haleakala board.
>
> Instead of duplicating this code in platform/40x/ which is already present in
> platforms/44x/misc_44x.S, why not move this misc_44x.S code into a common
> place for all 4xx (40x and 44x) PPC's? There seems to be nothing 44x
> specific.
>
> I suggest to introduce platforms/4xx/misc.S or sysdev/ppc4xx_misc.S with these
> functions and change the code referencing it accordingly.
>
> Comments/thoughts?
It's a good idea. I'd rather avoid platforms/4xx for now, but
sysdev/ppc4xx_misc.S seems reasonable.
I'll move it in my tree soon and do the necessary makefile fixups.
josh
prev parent reply other threads:[~2008-03-01 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 23:28 [PATCH] [POWERPC] 40X: Add Default Restart Machdep Method to 40X Platforms Grant Erickson
2008-02-23 16:37 ` Josh Boyer
2008-03-01 11:32 ` Stefan Roese
2008-03-01 13:15 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080301071535.643a5d93@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=erick205@umn.edu \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).