linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: paulus@samba.org
Cc: linuxppc-dev@ozlabs.org, arnd@arndb.de
Subject: [PATCH 2/2 v2] [POWERPC] Ignore disabled serial ports
Date: Sat, 1 Mar 2008 08:17:46 -0600	[thread overview]
Message-ID: <20080301081746.689a0a17@zod.rchland.ibm.com> (raw)
In-Reply-To: <20080301081600.74598ce4@zod.rchland.ibm.com>

Some SoC chips have multiple serial ports on board.  The usability of these
ports can rely on various factors, ranging from pin sharing to unpopulated
connectors.  This checks for a status property in the serial node and ignores
the port if it is set to "disabled".

Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>

---
 arch/powerpc/kernel/legacy_serial.c |    4 ++++
 drivers/serial/of_serial.c          |    5 +++++
 2 files changed, 9 insertions(+)

--- linux-2.6.orig/drivers/serial/of_serial.c
+++ linux-2.6/drivers/serial/of_serial.c
@@ -72,6 +72,11 @@ static int __devinit of_platform_serial_
 	int port_type;
 	int ret;
 
+	if (!of_device_is_available(ofdev->node)) {
+		dev_info(&ofdev->dev, "Disabled serial port.  Ignored\n");
+		return -ENODEV;
+	}
+
 	if (of_find_property(ofdev->node, "used-by-rtas", NULL))
 		return -EBUSY;
 
--- linux-2.6.orig/arch/powerpc/kernel/legacy_serial.c
+++ linux-2.6/arch/powerpc/kernel/legacy_serial.c
@@ -54,6 +54,10 @@ static int __init add_legacy_port(struct
 	u32 clock = BASE_BAUD * 16;
 	int index;
 
+	/* Check the status property if present.  Ignore disabled devices */
+	if (!of_device_is_available(np))
+		return -1;
+
 	/* get clock freq. if present */
 	clk = of_get_property(np, "clock-frequency", NULL);
 	if (clk && *clk)

  reply	other threads:[~2008-03-01 14:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 14:16 [PATCH 1/2 v2] [OF] Add of_device_is_available function Josh Boyer
2008-03-01 14:17 ` Josh Boyer [this message]
2008-03-03  3:43   ` [PATCH 2/2 v2] [POWERPC] Ignore disabled serial ports Arnd Bergmann
2008-03-03  4:43     ` Josh Boyer
2008-03-03 19:09       ` Scott Wood
2008-03-03 19:21         ` Josh Boyer
2008-03-03 21:40           ` Nathan Lynch
2008-03-04  0:42             ` Arnd Bergmann
2008-03-01 14:41 ` [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs Josh Boyer
2008-03-01 21:33   ` Benjamin Herrenschmidt
2008-03-01 23:50     ` Josh Boyer
2008-03-02 19:43   ` Sean MacLennan
2008-03-02 22:23     ` Josh Boyer
2008-03-01 22:02 ` [PATCH 1/2 v2] [OF] Add of_device_is_available function Stephen Rothwell
2008-03-01 22:25   ` Josh Boyer
2008-03-01 23:48 ` [RESEND] " Josh Boyer
2008-03-24 11:39   ` Paul Mackerras
2008-03-24 11:45     ` Josh Boyer
2008-03-25  4:47     ` Sean MacLennan
2008-03-25 11:51       ` Josh Boyer
2008-03-26 14:25         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080301081746.689a0a17@zod.rchland.ibm.com \
    --to=jwboyer@linux.vnet.ibm.com \
    --cc=arnd@arndb.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).