linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: paulus@samba.org, benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs
Date: Sat, 1 Mar 2008 08:41:40 -0600	[thread overview]
Message-ID: <20080301084140.7abc703e@zod.rchland.ibm.com> (raw)
In-Reply-To: <20080301081600.74598ce4@zod.rchland.ibm.com>

Convert ibm_newemac to use the of_device_is_available function when checking
for unused/unwired EMACs.  We leave the current check for an "unused" property
to maintain backwards compatibility for older device trees.  Newer device
trees should simply use the standard "status" property in the EMAC node.

The taishan DTS file is updated to reflect this.

Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>

---
 arch/powerpc/boot/dts/taishan.dts |    4 ++--
 drivers/net/ibm_newemac/core.c    |    7 +++++--
 2 files changed, 7 insertions(+), 4 deletions(-)

--- linux-2.6.orig/arch/powerpc/boot/dts/taishan.dts
+++ linux-2.6/arch/powerpc/boot/dts/taishan.dts
@@ -234,7 +234,6 @@
 
 
 			EMAC0: ethernet@40000800 {
-				unused = <1>;
 				linux,network-index = <2>;
 				device_type = "network";
 				compatible = "ibm,emac-440gx", "ibm,emac4";
@@ -253,9 +252,9 @@
 				phy-map = <00000001>;
 				zmii-device = <&ZMII0>;
 				zmii-channel = <0>;
+				status = "disabled";
 			};
 		 	EMAC1: ethernet@40000900 {
-				unused = <1>;
 				linux,network-index = <3>;
 				device_type = "network";
 				compatible = "ibm,emac-440gx", "ibm,emac4";
@@ -274,6 +273,7 @@
 				phy-map = <00000001>;
  				zmii-device = <&ZMII0>;
 				zmii-channel = <1>;
+				status = "disabled";
 			};
 
 		 	EMAC2: ethernet@40000c00 {
--- linux-2.6.orig/drivers/net/ibm_newemac/core.c
+++ linux-2.6/drivers/net/ibm_newemac/core.c
@@ -2552,8 +2552,11 @@ static int __devinit emac_probe(struct o
 	struct device_node **blist = NULL;
 	int err, i;
 
-	/* Skip unused/unwired EMACS */
-	if (of_get_property(np, "unused", NULL))
+	/* Skip unused/unwired EMACS.  We leave the check for an unused
+	 * property here for now, but new flat device trees should set a
+	 * status property to "disabled" instead.
+	 */
+	if (of_get_property(np, "unused", NULL) || !of_device_is_available(np))
 		return -ENODEV;
 
 	/* Find ourselves in the bootlist if we are there */

  parent reply	other threads:[~2008-03-01 14:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 14:16 [PATCH 1/2 v2] [OF] Add of_device_is_available function Josh Boyer
2008-03-01 14:17 ` [PATCH 2/2 v2] [POWERPC] Ignore disabled serial ports Josh Boyer
2008-03-03  3:43   ` Arnd Bergmann
2008-03-03  4:43     ` Josh Boyer
2008-03-03 19:09       ` Scott Wood
2008-03-03 19:21         ` Josh Boyer
2008-03-03 21:40           ` Nathan Lynch
2008-03-04  0:42             ` Arnd Bergmann
2008-03-01 14:41 ` Josh Boyer [this message]
2008-03-01 21:33   ` [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs Benjamin Herrenschmidt
2008-03-01 23:50     ` Josh Boyer
2008-03-02 19:43   ` Sean MacLennan
2008-03-02 22:23     ` Josh Boyer
2008-03-01 22:02 ` [PATCH 1/2 v2] [OF] Add of_device_is_available function Stephen Rothwell
2008-03-01 22:25   ` Josh Boyer
2008-03-01 23:48 ` [RESEND] " Josh Boyer
2008-03-24 11:39   ` Paul Mackerras
2008-03-24 11:45     ` Josh Boyer
2008-03-25  4:47     ` Sean MacLennan
2008-03-25 11:51       ` Josh Boyer
2008-03-26 14:25         ` Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080301084140.7abc703e@zod.rchland.ibm.com \
    --to=jwboyer@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).