linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Blank <waldi@debian.org>
To: linuxppc-dev@ozlabs.org
Subject: [PATCH] powerpc - Use KBUILD_CFLAGS and similar
Date: Sun, 2 Mar 2008 20:06:32 +0100	[thread overview]
Message-ID: <20080302190632.GA9898@wavehammer.waldi.eu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

Hi folks

The attached patch changes the powerpc main Makefile from using the override
make directive to KBUILD_CFLAGS and similar.

The override approach breaks with both variants "CC=gcc-4.3 make" and
"make CC=gcc-4.3". The first ignores the given value completely because
the toplevel Makefile includes a CC definition:

| $ CC="gcc-4.3" make V=1
[...]
|  gcc -m64 -Wp,-MD,init/.main.o.d

The second does not add -m64:
| $ make CC="gcc-4.3" V=1
[...]
|  gcc-4.3 -Wp,-MD,arch/powerpc/kernel/.asm-offsets.s.d

The patch changes the CC, AS and LD overrides into changes of
KBUILD_CFLAGS, KBUILD_AFLAGS and LDFLAGS similar to arch/s390/Makefile.

Signed-off-by: Bastian Blank <waldi@debian.org>

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index 1c6ce35..b267c60 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -63,9 +63,9 @@ endif
 UTS_MACHINE := $(OLDARCH)
 
 ifeq ($(HAS_BIARCH),y)
-override AS    += -a$(CONFIG_WORD_SIZE)
-override LD    += -m elf$(CONFIG_WORD_SIZE)ppc
-override CC    += -m$(CONFIG_WORD_SIZE)
+LDFLAGS                := -m elf$(CONFIG_WORD_SIZE)ppc
+KBUILD_CFLAGS  += -m$(CONFIG_WORD_SIZE)
+KBUILD_AFLAGS  += -m$(CONFIG_WORD_SIZE)
 override AR    := GNUTARGET=elf$(CONFIG_WORD_SIZE)-powerpc $(AR)
 endif
 
-- 
Men will always be men -- no matter where they are.
		-- Harry Mudd, "Mudd's Women", stardate 1329.8

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2008-03-02 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 19:06 Bastian Blank [this message]
2008-04-07  3:27 ` [PATCH] powerpc - Use KBUILD_CFLAGS and similar Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080302190632.GA9898@wavehammer.waldi.eu.org \
    --to=waldi@debian.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).