* [PATCH 1/1] Cell RAS: Remove DEBUG, and add license and copyright
@ 2008-02-14 2:34 Michael Ellerman
2008-03-03 4:18 ` [Cbe-oss-dev] " Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2008-02-14 2:34 UTC (permalink / raw)
To: linuxppc-dev; +Cc: cbe-oss-dev
arch/powerpc/platforms/cell/ras.c still has DEBUG #defined, which is no
longer neccessary. Disable it, this disables to pr_debugs().
While we're there this file should have a copyright notice and license,
so add both.
Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
---
arch/powerpc/platforms/cell/ras.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/cell/ras.c b/arch/powerpc/platforms/cell/ras.c
index b2494eb..e43024c 100644
--- a/arch/powerpc/platforms/cell/ras.c
+++ b/arch/powerpc/platforms/cell/ras.c
@@ -1,4 +1,13 @@
-#define DEBUG
+/*
+ * Copyright 2006-2008, IBM Corporation.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version
+ * 2 of the License, or (at your option) any later version.
+ */
+
+#undef DEBUG
#include <linux/types.h>
#include <linux/kernel.h>
--
1.5.2.rc1.1884.g59b20
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Cbe-oss-dev] [PATCH 1/1] Cell RAS: Remove DEBUG, and add license and copyright
2008-02-14 2:34 [PATCH 1/1] Cell RAS: Remove DEBUG, and add license and copyright Michael Ellerman
@ 2008-03-03 4:18 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2008-03-03 4:18 UTC (permalink / raw)
To: Michael Ellerman; +Cc: linuxppc-dev, cbe-oss-dev
On Thu, Feb 14, 2008 at 01:34:17PM +1100, Michael Ellerman wrote:
> arch/powerpc/platforms/cell/ras.c still has DEBUG #defined, which is no
> longer neccessary. Disable it, this disables to pr_debugs().
No need to undef it, it's undefined by default. Otherwise the patch
looks fine to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-03 4:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-14 2:34 [PATCH 1/1] Cell RAS: Remove DEBUG, and add license and copyright Michael Ellerman
2008-03-03 4:18 ` [Cbe-oss-dev] " Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).