From: David Gibson <dwg@au1.ibm.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>,
linuxppc-dev <linuxppc-dev@ozlabs.org>,
Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: Bamboo PCI interrupt issues
Date: Tue, 4 Mar 2008 13:15:03 +1100 [thread overview]
Message-ID: <20080304021503.GH1393@localhost.localdomain> (raw)
In-Reply-To: <08b18695c383fb829ecf3ab6c2822bd1@kernel.crashing.org>
On Tue, Mar 04, 2008 at 03:07:50AM +0100, Segher Boessenkool wrote:
> >>> Uh.. there's no binding written down, it's just encoded into uic.c.
> >>> But UIC doesn't use OpenPIC sensitivity encoding. Like FSL's IPIC,
> >>> it
> >>> uses Linux IRQ_TYPE values from include/linux/irq.h which makes 8
> >>> "level sensitive, active-low".
> >>
> >> On a related note: aren't we taking a risk here of seeing those values
> >> change in linux ?
> >
> > We've discussed this before. If that happens, the binding must remain
> > on the old values. It means the driver will then need a translation
> > which it doesn't now, but we can deal with it.
>
> It also means it should be written down in the binding _already_.
Well, yes, there should be, but isn't, a written binding for this,
amongst many other things.
> Come on, how much work is that?
Greater than zero.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-03-04 2:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 0:02 Bamboo PCI interrupt issues Hollis Blanchard
2008-03-04 0:59 ` David Gibson
2008-03-04 1:42 ` Benjamin Herrenschmidt
2008-03-04 1:53 ` David Gibson
2008-03-04 2:07 ` Segher Boessenkool
2008-03-04 2:15 ` David Gibson [this message]
2008-03-04 3:37 ` Josh Boyer
2008-03-04 6:15 ` Stefan Roese
2008-03-04 6:33 ` Benjamin Herrenschmidt
2008-03-04 20:39 ` Segher Boessenkool
2008-03-04 20:41 ` Benjamin Herrenschmidt
2008-03-04 20:59 ` Segher Boessenkool
2008-03-04 21:01 ` Benjamin Herrenschmidt
2008-03-04 6:18 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080304021503.GH1393@localhost.localdomain \
--to=dwg@au1.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=kvm-ppc-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).