From: Scott Wood <scottwood@freescale.com>
To: Jon Loeliger <jdl@freescale.com>, linuxppc-dev@ozlabs.org
Subject: Re: dtc: Make some functions local to parser
Date: Tue, 4 Mar 2008 13:18:44 -0600 [thread overview]
Message-ID: <20080304191844.GA7810@loki.buserror.net> (raw)
In-Reply-To: <20080304043700.GB2757@localhost.localdomain>
On Tue, Mar 04, 2008 at 03:37:00PM +1100, David Gibson wrote:
> * The Bison documentation explicitly permits yyerror() to be a
> variadic function, so fold yyerror() and yyerrorf() into a single
> printf-style function.
Then the bison documentation is not consistent with the bison
implementation when verbose error messages are enabled. How can it possibly
know whether to put % or %% in the string when an unexpected % is
encountered?
Reading bison internals makes my head hurt...
> The combined function is defined and used
> only in the parse, so make it static.
Static-izing something that is used externally in a posted patch where
you've provided no alternate to use is rather bad form...
-Scott
next prev parent reply other threads:[~2008-03-04 19:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 4:37 dtc: Make some functions local to parser David Gibson
2008-03-04 19:18 ` Scott Wood [this message]
2008-03-05 0:38 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080304191844.GA7810@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=jdl@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).