Re: [PATCH 3/4] Emerson KSI8560 device tree

[David Gibson <david@gibson.dropbear.id.au>]

On Tue, Mar 04, 2008 at 07:35:40PM +0300, Alexandr Smirnov wrote:
> Add device tree file for Emerson KSI8560 board.
> 
> Signed-off-by: Alexandr Smirnov <asmirnov@ru.mvista.com>

[snip]
> +		enet0: ethernet@24000 {
> +			linux,network-index = <0>;

We're trying to get rid of this.  Since I assume you're using u-boot,
I'm not sure why you'd need it now anyway.

> +			device_type = "network";
> +			model = "TSEC";
> +			compatible = "gianfar";

This still looks like the old binding.

[snip]
> +		cpld@4,0 {
> +			compatible = "altera,maxii";

I'm guessing an Altera Maxii is just the name of the FPGA chip into
which the CPLD is programmed?  If so, it's not a suitable "comaptible"
value, because that needs to describe the register interface.  You
probably want something like
	compatible = "emerson,KSI8560-cpld";
here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson