From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: dtc: Make some functions local to parser
Date: Wed, 5 Mar 2008 11:38:01 +1100 [thread overview]
Message-ID: <20080305003801.GF8399@localhost.localdomain> (raw)
In-Reply-To: <20080304191844.GA7810@loki.buserror.net>
On Tue, Mar 04, 2008 at 01:18:44PM -0600, Scott Wood wrote:
> On Tue, Mar 04, 2008 at 03:37:00PM +1100, David Gibson wrote:
> > * The Bison documentation explicitly permits yyerror() to be a
> > variadic function, so fold yyerror() and yyerrorf() into a single
> > printf-style function.
>
> Then the bison documentation is not consistent with the bison
> implementation when verbose error messages are enabled. How can it possibly
> know whether to put % or %% in the string when an unexpected % is
> encountered?
Ah crap. I'd forgotten the specific case you mentioned before.
> Reading bison internals makes my head hurt...
>
> > The combined function is defined and used
> > only in the parse, so make it static.
>
> Static-izing something that is used externally in a posted patch where
> you've provided no alternate to use is rather bad form...
IIRC, I already asked you *not* to use it externally, though. And a
lot of these patches I've been posting lately are yak-shaving leading
up to a generally available error function.
Still, forget this patch for now.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2008-03-05 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 4:37 dtc: Make some functions local to parser David Gibson
2008-03-04 19:18 ` Scott Wood
2008-03-05 0:38 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305003801.GF8399@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).