From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from phobos.cabal.ca (206-248-169-182.dsl.ncf.ca [206.248.169.182]) by ozlabs.org (Postfix) with ESMTP id 4A557DDFAF for ; Thu, 6 Mar 2008 03:17:12 +1100 (EST) Date: Wed, 5 Mar 2008 11:17:10 -0500 From: Kyle McMartin To: Bjorn Helgaas Subject: Re: [patch 09/16] parisc: use generic pci_enable_resources() Message-ID: <20080305161709.GA3354@phobos.i.cabal.ca> References: <20080304185646.864917286@ldl.fc.hp.com> <20080304185821.554040328@ldl.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20080304185821.554040328@ldl.fc.hp.com> Cc: linux-arch@vger.kernel.org, Chris Zankel , Grant Grundler , linux-parisc@vger.kernel.org, Matthew Wilcox , Kyle McMartin , linuxppc-dev@ozlabs.org, Paul Mackerras , linux-pci@atrey.karlin.mff.cuni.cz, Russell King List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Mar 04, 2008 at 11:56:55AM -0700, Bjorn Helgaas wrote: > Use the generic pci_enable_resources() instead of the arch-specific code. > > Unlike this arch-specific code, the generic version: > - checks PCI_NUM_RESOURCES (11), not DEVICE_COUNT_RESOURCE (12), resources > - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set > - skips ROM resources unless IORESOURCE_ROM_ENABLE is set > - checks for resource collisions with "!r->parent" > > Signed-off-by: Bjorn Helgaas > Acked-by: Kyle McMartin