From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from honk.sigxcpu.org (static-87-79-238-240.netcologne.de [87.79.238.240]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "honk.sigxcpu.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTP id 795AADE070 for ; Sun, 9 Mar 2008 06:21:27 +1100 (EST) Date: Sat, 8 Mar 2008 20:20:17 +0100 From: Guido =?iso-8859-1?Q?G=FCnther?= To: linuxppc-dev@ozlabs.org Subject: [PATCH] Export pmu_* variables unconditionally Message-ID: <20080308192017.GC26962@bogon.ms20.nix> References: <20080227141452.GA10345@bogon.ms20.nix> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20080227141452.GA10345@bogon.ms20.nix> Cc: paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, This is a resend, since it's still unfixed in current Linus git and I didn't see any comments (please cc: me since I'm not subscribed): Otherwise without CONFIG_SUSPEND we have: ERROR: "pmu_batteries" [drivers/macintosh/apm_emu.ko] undefined! ERROR: "pmu_battery_count" [drivers/macintosh/apm_emu.ko] undefined! ERROR: "pmu_power_flags" [drivers/macintosh/apm_emu.ko] undefined! on PPC32. The variables aren't wrapped in '#if defined(CONFIG_SUSPEND)' so we probably shouldn't wrap the exports either. Fixes compilation on ppc32. Signed-off-by: Guido Guenther --- drivers/macintosh/via-pmu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index 296edcb..399fc7f 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@ -2528,7 +2528,7 @@ EXPORT_SYMBOL(pmu_wait_complete); EXPORT_SYMBOL(pmu_suspend); EXPORT_SYMBOL(pmu_resume); EXPORT_SYMBOL(pmu_unlock); -#if defined(CONFIG_SUSPEND) && defined(CONFIG_PPC32) +#if defined(CONFIG_PPC32) EXPORT_SYMBOL(pmu_enable_irled); EXPORT_SYMBOL(pmu_battery_count); EXPORT_SYMBOL(pmu_batteries); -- 1.5.4.2