From: Anton Blanchard <anton@samba.org>
To: linuxppc-dev@ozlabs.org
Cc: paulus@samba.org
Subject: [PATCH] Fix PMU + soft interrupt disable bug
Date: Sun, 16 Mar 2008 23:27:09 -0500 [thread overview]
Message-ID: <20080317042709.GA10594@kryten> (raw)
Since the PMU is an NMI now, it can come at any time we are only soft
disabled. We must hard disable around the two places we allow the kernel
stack SLB and r1 to go out of sync. Otherwise the PMU exception can
force a kernel stack SLB into another slot.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
Index: kernel/arch/powerpc/mm/slb.c
===================================================================
--- kernel.orig/arch/powerpc/mm/slb.c 2007-11-05 11:22:03.000000000 -0600
+++ kernel/arch/powerpc/mm/slb.c 2007-11-05 18:09:45.000000000 -0600
@@ -113,6 +113,12 @@ void slb_flush_and_rebolt(void)
slb_shadow_update(get_paca()->kstack, lflags, 2);
}
+ /*
+ * We can't take a PMU exception in the following code, so hard
+ * disable interrupts.
+ */
+ hard_irq_disable();
+
/* We need to do this all in asm, so we're sure we don't touch
* the stack between the slbia and rebolting it. */
asm volatile("isync\n"
Index: kernel/arch/powerpc/kernel/process.c
===================================================================
--- kernel.orig/arch/powerpc/kernel/process.c 2007-11-05 18:10:44.000000000 -0600
+++ kernel/arch/powerpc/kernel/process.c 2007-11-05 18:10:46.000000000 -0600
@@ -331,6 +331,12 @@ struct task_struct *__switch_to(struct t
account_process_vtime(current);
calculate_steal_time();
+ /*
+ * We can't take a PMU exception inside _switch() since there is a
+ * window where the kernel stack SLB and the kernel stack are out
+ * of sync. Hard disable here.
+ */
+ hard_irq_disable();
last = _switch(old_thread, new_thread);
local_irq_restore(flags);
next reply other threads:[~2008-03-17 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 4:27 Anton Blanchard [this message]
2008-03-17 8:51 ` [PATCH] Fix PMU + soft interrupt disable bug Benjamin Herrenschmidt
2008-03-18 0:36 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080317042709.GA10594@kryten \
--to=anton@samba.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).