LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "John Linn" <John.Linn@xilinx.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: RE: [PATCH] [POWERPC] Xilinx: Boot: Fix 16550 UART initialization
Date: Mon, 17 Mar 2008 14:10:33 -0600	[thread overview]
Message-ID: <20080317201035.CBCAC1468068@mail95-dub.bigfish.com> (raw)
In-Reply-To: <fa686aa40803171308h5ef7f8a9m5119ef12d8c87980@mail.gmail.com>

Great, I'll do that.

Does this also apply to my other patch, Adding 8250 console support to
OF serial, as it's not clear to me when to assume the UART is already
setup or not?

Thanks,
John

-----Original Message-----
From: glikely@secretlab.ca [mailto:glikely@secretlab.ca] On Behalf Of
Grant Likely
Sent: Monday, March 17, 2008 2:08 PM
To: John Linn
Cc: linuxppc-dev@ozlabs.org; jwboyer@linux.vnet.ibm.com
Subject: Re: [PATCH] [POWERPC] Xilinx: Boot: Fix 16550 UART
initialization

On Mon, Mar 17, 2008 at 1:57 PM, John Linn <John.Linn@xilinx.com> wrote:
> That makes sense.  Since I'm not using a boot loader I didn't realize
>  that.
>
>  I'm not sure how hard it will be to get the data from the device tree
at
>  that time.

You should be good.  It is now possible to read data from the device
tree at platform_init() time.

Cheers,
g.

>  What about checking to see if it's setup assuming that's possible by
>  looking at registers, and then not messing with it if it's already
>  setup, otherwise do what my patch does.

Ugh.  The old arch/ppc code used to do this and it was kind of ugly
and fragile.  I'd rather avoid doing it again.

Cheers,
g.

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2008-03-17 20:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 16:41 [PATCH] [POWERPC] Xilinx: Boot: Fix 16550 UART initialization John Linn
2008-03-17 19:47 ` Grant Likely
2008-03-17 19:57   ` John Linn
2008-03-17 20:08     ` Grant Likely
2008-03-17 20:10       ` John Linn [this message]
2008-03-17 20:13         ` Grant Likely
2008-03-17 20:17       ` Stephen Neuendorffer
2008-03-17 20:24         ` Grant Likely
2008-03-17 20:25           ` Stephen Neuendorffer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317201035.CBCAC1468068@mail95-dub.bigfish.com \
    --to=john.linn@xilinx.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox