linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, Adrian Bunk <bunk@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	linux-kernel@vger.kernel.org
Subject: Re: powerpc: cuImage.* creation error
Date: Mon, 17 Mar 2008 18:46:08 -0400	[thread overview]
Message-ID: <20080317224607.GA10732@windriver.com> (raw)
In-Reply-To: <fa686aa40803171541t6357d304i2e7e5292f084d09d@mail.gmail.com>

In message: Re: powerpc: cuImage.* creation error
on 17/03/2008 Grant Likely wrote:

> On Mon, Mar 17, 2008 at 2:07 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > In message: powerpc: cuImage.* creation error
> >
> >  @@ -253,8 +253,8 @@ image-$(CONFIG_TQM8540)                     += cuImage.tqm8540
> >   image-$(CONFIG_TQM8541)                        += cuImage.tqm8541
> >   image-$(CONFIG_TQM8555)                        += cuImage.tqm8555
> >   image-$(CONFIG_TQM8560)                        += cuImage.tqm8560
> >  -image-$(CONFIG_SBC8548)                        += cuImage.tqm8548
> >  -image-$(CONFIG_SBC8560)                        += cuImage.tqm8560
> >  +image-$(CONFIG_SBC8548)                        += cuImage.sbc8548
> >  +image-$(CONFIG_SBC8560)                        += cuImage.sbc8560
> 
> No, the suffix in the cuImage targets has a 1:1 relationship with dts
> files in arch/powerpc/boot/dts/.  If a file doesn't exist there, then
> the target cannot be built.

You should have both the sbc8548.dts and the sbc8560.dts in your tree.
They have been in there for several weeks now.

I just tested with the above here, and I was just about to hit send on
this extra chunk to fix the second half of the problem.

Note that I didn't lump the tqm8540 in with the other tqm, because the
defconfig tends to indicate it doesn't need 85xx-cpm2;  just 85xx.

Thanks,
Paul.

--

Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date:   Mon Mar 17 18:33:52 2008 -0400

    wrapper: Add entries for tqm8540 and sbc85xx
    
    The wrapper script didn't have entries for the TQM8540 board and the
    SBC8548 or SBC8560 boards.  I've assumed that the TQM8540 console is
    8250 based and not CPM based by looking at its defconfig.  There was
    also a trailing * on the TQM8555 entry that I removed too.
    
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index d50e498..8ec8ea8 100755
--- a/arch/powerpc/boot/wrapper
+++ b/arch/powerpc/boot/wrapper
@@ -174,7 +174,10 @@ cuboot*)
     *-mpc83*)
         platformo=$object/cuboot-83xx.o
         ;;
-    *-tqm8541|*-mpc8560*|*-tqm8560|*-tqm8555*)
+    *-tqm8540|*-sbc85*)
+        platformo=$object/cuboot-85xx.o
+        ;;
+    *-tqm8541|*-mpc8560*|*-tqm8560|*-tqm8555)
         platformo=$object/cuboot-85xx-cpm2.o
         ;;
     *-mpc85*)

  reply	other threads:[~2008-03-17 22:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-17 19:36 powerpc: cuImage.* creation error Adrian Bunk
2008-03-17 19:39 ` Grant Likely
2008-03-17 20:07 ` Paul Gortmaker
2008-03-17 22:23   ` Adrian Bunk
2008-03-17 22:41   ` Grant Likely
2008-03-17 22:46     ` Paul Gortmaker [this message]
2008-03-17 23:22       ` Grant Likely
2008-03-18  5:10         ` Grant Likely
2008-03-17 22:39 ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080317224607.GA10732@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=bunk@kernel.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).