LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Alexandr Smirnov <asmirnov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/4] Emerson ATCA-C125 bootwrapper
Date: Tue, 18 Mar 2008 12:28:18 +1100	[thread overview]
Message-ID: <20080318012818.GB18217@localhost.localdomain> (raw)
In-Reply-To: <47DE61E1.6060300@ru.mvista.com>

On Mon, Mar 17, 2008 at 03:19:45PM +0300, Alexandr Smirnov wrote:
> David,
>>> +	/* Unfortunately, the specific model number is encoded in the
>>> +	 * soc node name in existing dts files -- once that is fixed,
>>> +	 * this can do a simple path lookup.
>>> +	 */
>>>     
>>
>> Since this is a new board, couldn't you name the soc node /soc and
>> dispense with this more complicated way of doing things?  Or would
>> that break other versions of u-boot that are in use?
>>   
> As I understand you would like to rename /soc8548 node to /soc and make a 
> simple path lookup like following:
> - soc = find_node_by_devtype(NULL, "soc");
> + soc = finddevice("/soc");
> Is this correct?

That's right.

> But fsl_soc code still uses of_find_node_by_type so we can't remove 
> device_type property from node /soc and therefor simplify device
> tree.

It does?  Grrr...  I thought that had been fixed and the only reason
the device_type was still needed was because some u-boot versions
needed it.  But you're right, that's not the case.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2008-03-18  1:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14 14:22 PATCH [0/4] Add support for Emerson ATCA-C125 board Alexandr Smirnov
2008-03-14 14:27 ` [PATCH 1/4] Emerson ATCA-C125 bootwrapper Alexandr Smirnov
2008-03-15  0:10   ` David Gibson
2008-03-17 12:19     ` Alexandr Smirnov
2008-03-18  1:28       ` David Gibson [this message]
2008-03-14 14:28 ` [PATCH 2/4] Emerson ATCA-C125 device tree Alexandr Smirnov
2008-03-14 14:29 ` [PATCH 3/4] Emerson ATCA-C125 default config Alexandr Smirnov
2008-03-14 14:30 ` [PATCH 4/4] Emerson ATCA-C125 base support Alexandr Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080318012818.GB18217@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=asmirnov@ru.mvista.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox