From: Roland McGrath <roland@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-arch@vger.kernel.org, tony.luck@intel.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>,
sparclinux@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Henderson <rth@twiddle.net>
Subject: [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return
Date: Wed, 19 Mar 2008 14:20:24 -0700 (PDT) [thread overview]
Message-ID: <20080319212024.EA03126F995@magilla.localdomain> (raw)
In-Reply-To: Roland McGrath's message of Wednesday, 19 March 2008 14:17:14 -0700 <20080319211714.8B14226F995@magilla.localdomain>
The arch_ptrace and compat_arch_ptrace functions can now return
-ENOSYS for requests they do not actually implement in arch
code. Returning -ENOSYS replaces the calls to ptrace_request
and compat_ptrace_request. This leaves more latitude for the
machine-independent ptrace implementation code to change without
requiring any more updates in the arch code.
This change has no effect on the old arch code that still calls
ptrace_request or compat_ptrace_request.
Signed-off-by: Roland McGrath <roland@redhat.com>
---
kernel/ptrace.c | 42 ++++++++++++++++++++++++++----------------
1 files changed, 26 insertions(+), 16 deletions(-)
diff --git a/kernel/ptrace.c b/kernel/ptrace.c
index 67e392e..60b2b57 100644
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -574,18 +574,21 @@ asmlinkage long sys_ptrace(long request, long pid, long addr, long data)
*/
if (!ret)
arch_ptrace_attach(child);
- goto out_put_task_struct;
+ } else {
+ ret = ptrace_check_attach(child, request == PTRACE_KILL);
+ /*
+ * Let the arch handler inspect it first. It returns
+ * -ENOSYS if this is not an arch-specific request.
+ */
+ if (!ret) {
+ ret = arch_ptrace(child, request, addr, data);
+ if (ret == -ENOSYS &&
+ !forced_successful_syscall_return())
+ ret = ptrace_request(child, request,
+ addr, data);
+ }
}
- ret = ptrace_check_attach(child, request == PTRACE_KILL);
- if (ret < 0)
- goto out_put_task_struct;
-
- ret = arch_ptrace(child, request, addr, data);
- if (ret < 0)
- goto out_put_task_struct;
-
- out_put_task_struct:
put_task_struct(child);
out:
unlock_kernel();
@@ -697,14 +700,21 @@ asmlinkage long compat_sys_ptrace(compat_long_t request, compat_long_t pid,
*/
if (!ret)
arch_ptrace_attach(child);
- goto out_put_task_struct;
+ } else {
+ ret = ptrace_check_attach(child, request == PTRACE_KILL);
+ /*
+ * Let the arch handler inspect it first. It returns
+ * -ENOSYS if this is not an arch-specific request.
+ */
+ if (!ret) {
+ ret = compat_arch_ptrace(child, request, addr, data);
+ if (ret == -ENOSYS &&
+ !forced_successful_syscall_return())
+ ret = compat_ptrace_request(child, request,
+ addr, data);
+ }
}
- ret = ptrace_check_attach(child, request == PTRACE_KILL);
- if (!ret)
- ret = compat_arch_ptrace(child, request, addr, data);
-
- out_put_task_struct:
put_task_struct(child);
out:
unlock_kernel();
next prev parent reply other threads:[~2008-03-19 21:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 21:17 [PATCH 1/8] ptrace: forced_successful_syscall_return() macro Roland McGrath
2008-03-19 21:18 ` [PATCH 2/8] alpha ptrace: forced_successful_syscall_return() Roland McGrath
2008-03-19 21:19 ` [PATCH 3/8] ia64 " Roland McGrath
2008-03-19 21:19 ` [PATCH 4/8] powerpc " Roland McGrath
2008-03-24 7:55 ` Paul Mackerras
2008-03-19 21:20 ` [PATCH 5/8] sparc64 " Roland McGrath
2008-03-19 21:30 ` David Miller
2008-03-19 21:20 ` Roland McGrath [this message]
2008-03-20 2:40 ` [PATCH 6/8] ptrace: arch_ptrace -ENOSYS return Linus Torvalds
2008-03-20 7:40 ` Christoph Hellwig
2008-03-20 8:16 ` Roland McGrath
2008-03-21 13:50 ` Thomas Gleixner
2008-03-21 14:07 ` Christoph Hellwig
2008-03-21 14:10 ` Sam Ravnborg
2008-03-21 14:55 ` Linus Torvalds
2008-03-21 15:07 ` Ingo Molnar
2008-03-19 21:20 ` [PATCH 7/8] x86 " Roland McGrath
2008-03-19 21:21 ` [PATCH 8/8] powerpc " Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080319212024.EA03126F995@magilla.localdomain \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rth@twiddle.net \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox