From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, John Linn <john.linn@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/3] [POWERPC] of_serial: Fix possible null dereference.
Date: Thu, 20 Mar 2008 20:41:03 -0500 [thread overview]
Message-ID: <20080320204103.1f744e27@zod.rchland.ibm.com> (raw)
In-Reply-To: <fa686aa40803201658g6fbdcab0he06dd1e3c83ca900@mail.gmail.com>
On Thu, 20 Mar 2008 17:58:07 -0600
"Grant Likely" <grant.likely@secretlab.ca> wrote:
> On Thu, Mar 20, 2008 at 8:43 AM, John Linn <john.linn@xilinx.com> wrote:
> > From: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
> >
> > The of_serial driver queries the current-speed property and attempts
> > to use it to register the custom_divisor property of the uart_port.
> > However, if current-speed is not set, then this code will dereference
> > a bad pointer. The fix is to only set custom_divisor when a
> > current-speed property appears in the device tree.
> >
> > Signed-off-by: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
> > Signed-off-by: John Linn <john.linn@xilinx.com>
>
> This looks correct and appropriate to me.
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Agreed.
Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> Josh/Arnd, could either of you pick this up?
Arnd, can you send this on to Andrew? Or if you are busy I can.
josh
> > ---
> > drivers/serial/of_serial.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
> > index a64d858..2efb892 100644
> > --- a/drivers/serial/of_serial.c
> > +++ b/drivers/serial/of_serial.c
> > @@ -56,7 +56,9 @@ static int __devinit of_platform_serial_setup(struct of_device *ofdev,
> > port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP
> > | UPF_FIXED_PORT;
> > port->dev = &ofdev->dev;
> > - port->custom_divisor = *clk / (16 * (*spd));
> > + /* If current-speed was set, then try not to change it. */
> > + if (spd)
> > + port->custom_divisor = *clk / (16 * (*spd));
> >
> > return 0;
> > }
> > --
> > 1.5.2.1
> >
> >
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@ozlabs.org
> > https://ozlabs.org/mailman/listinfo/linuxppc-dev
> >
>
>
>
prev parent reply other threads:[~2008-03-21 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 14:43 [PATCH 1/3] [POWERPC] of_serial: Fix possible null dereference John Linn
2008-03-20 23:58 ` Grant Likely
2008-03-21 1:41 ` Josh Boyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080320204103.1f744e27@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=john.linn@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).