From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail114-dub-R.bigfish.com (mail-dub.bigfish.com [213.199.154.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.bigfish.com", Issuer "Microsoft Secure Server Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id BE720DDFCB for ; Sat, 22 Mar 2008 03:50:41 +1100 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Subject: RE: [PATCH 2/3] [POWERPC] Xilinx: of_serial support for Xilinx uart16550. Date: Fri, 21 Mar 2008 09:50:36 -0700 In-Reply-To: <0a442bfb97492bd8d687678480c6217a@kernel.crashing.org> References: <12060242324116-git-send-email-john.linn@xilinx.com> <20080320144402.3063517C005D@mail148-sin.bigfish.com><47E3B189.6060002@ru.mvista.com><75a17dc1bd4e99a473ed679ccf9b210f@kernel.crashing.org><47E3DA40.6000007@ru.mvista.com> <0a442bfb97492bd8d687678480c6217a@kernel.crashing.org> From: "Stephen Neuendorffer" To: "Segher Boessenkool" , "Sergei Shtylyov" Message-Id: <20080321165034.6D7F2440086@mail114-dub.bigfish.com> Cc: John Linn , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -----Original Message----- > From: = linuxppc-dev-bounces+stephen.neuendorffer=3Dxilinx.com@ozlabs.org [mailto:linuxppc-dev- > bounces+stephen.neuendorffer=3Dxilinx.com@ozlabs.org] On Behalf Of Segher Boessenkool > Sent: Friday, March 21, 2008 9:46 AM > To: Sergei Shtylyov > Cc: linuxppc-dev@ozlabs.org; John Linn > Subject: Re: [PATCH 2/3] [POWERPC] Xilinx: of_serial support for Xilinx uart16550. >=20 > > The proposed use clearly would treat them as generic, since in the > > context of the Xilinx UART they're just not needed -- it's known > > beforehand and most probably fixed how/where the registers are mapped. > > There's just no need for such info in the device tree -- unless you're > > going to teach the *generic* driver to handle this specific (and > > possibly others alike) kind of a device. >=20 > I was under the impression that the "xilinx uart" was just a 16550 (or > so) > with its registers wired up in a slightly unusual way. If it's a > completely > different device, of course you need a separate binding, and you might > not > want reg-shift properties etc. there. It's a standard 16550, with registers in the standard order, but at offsets 3,7,11, etc. Steve