linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Jon Loeliger <jdl@freescale.com>, linuxppc-dev@ozlabs.org
Subject: Re: dtc: Simplify error handling for unparseable input
Date: Mon, 24 Mar 2008 12:36:41 -0500	[thread overview]
Message-ID: <20080324173641.GA22159@loki.buserror.net> (raw)
In-Reply-To: <20080324034424.GC29985@localhost.localdomain>

On Mon, Mar 24, 2008 at 02:44:24PM +1100, David Gibson wrote:
> Index: dtc/dtc.h
> ===================================================================
> --- dtc.orig/dtc.h	2008-03-24 14:33:33.000000000 +1100
> +++ dtc/dtc.h	2008-03-24 14:33:34.000000000 +1100
> @@ -232,7 +232,6 @@
>  struct boot_info {
>  	struct reserve_info *reservelist;
>  	struct node *dt;		/* the device tree */
> -	int error;
>  };

If you remove this, there'll be no way to indicate semantic errors other
than die() (the NULL approaches are no good, since they inhibit recovery),
which is suboptimal if the error is not immediately fatal.

-Scott

  reply	other threads:[~2008-03-24 17:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-24  3:44 dtc: Simplify error handling for unparseable input David Gibson
2008-03-24 17:36 ` Scott Wood [this message]
2008-03-25  1:28   ` David Gibson
2008-03-25 14:36     ` Scott Wood
2008-03-25 21:21       ` David Gibson
2008-03-25 22:10         ` Scott Wood
2008-03-25 23:52           ` David Gibson
2008-03-26  1:16             ` Scott Wood
2008-03-25 23:59           ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080324173641.GA22159@loki.buserror.net \
    --to=scottwood@freescale.com \
    --cc=jdl@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).