From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RESEND] [PATCH 1/2 v2] [OF] Add of_device_is_available function
Date: Tue, 25 Mar 2008 06:51:58 -0500 [thread overview]
Message-ID: <20080325065158.6c299e05@zod.rchland.ibm.com> (raw)
In-Reply-To: <20080325004753.5885ede9@lappy.seanm.ca>
On Tue, 25 Mar 2008 00:47:53 -0400
Sean MacLennan <smaclennan@pikatech.com> wrote:
> On Mon, 24 Mar 2008 22:39:18 +1100
> "Paul Mackerras" <paulus@samba.org> wrote:
>
> > The second test will succeed for anything that starts with "ok", so
> > the first test is redundant. I suspect you want strcmp instead of
> > strncmp in both tests.
>
> I like the strncmp(status, "ok", 2). Then you can have a status of
> okey-dokey ;)
You can also have "oklahoma", "okaly-dokaly-do" (I hate Ned Flanders),
and "ok-this-device-is-fubar-don't-ever-touch-it!"
We really want just "okay" and "ok". Look for a version 3 of the patch
that fixes it later today.
josh
next prev parent reply other threads:[~2008-03-25 11:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-01 14:16 [PATCH 1/2 v2] [OF] Add of_device_is_available function Josh Boyer
2008-03-01 14:17 ` [PATCH 2/2 v2] [POWERPC] Ignore disabled serial ports Josh Boyer
2008-03-03 3:43 ` Arnd Bergmann
2008-03-03 4:43 ` Josh Boyer
2008-03-03 19:09 ` Scott Wood
2008-03-03 19:21 ` Josh Boyer
2008-03-03 21:40 ` Nathan Lynch
2008-03-04 0:42 ` Arnd Bergmann
2008-03-01 14:41 ` [PATCH 3/2][NEWEMAC] Use status property for unused/unwired EMACs Josh Boyer
2008-03-01 21:33 ` Benjamin Herrenschmidt
2008-03-01 23:50 ` Josh Boyer
2008-03-02 19:43 ` Sean MacLennan
2008-03-02 22:23 ` Josh Boyer
2008-03-01 22:02 ` [PATCH 1/2 v2] [OF] Add of_device_is_available function Stephen Rothwell
2008-03-01 22:25 ` Josh Boyer
2008-03-01 23:48 ` [RESEND] " Josh Boyer
2008-03-24 11:39 ` Paul Mackerras
2008-03-24 11:45 ` Josh Boyer
2008-03-25 4:47 ` Sean MacLennan
2008-03-25 11:51 ` Josh Boyer [this message]
2008-03-26 14:25 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325065158.6c299e05@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).