From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e33.co.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 7F5A2DDE21 for ; Wed, 26 Mar 2008 23:39:06 +1100 (EST) Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e33.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m2QCd3ML015065 for ; Wed, 26 Mar 2008 08:39:03 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2QCd2G6141690 for ; Wed, 26 Mar 2008 06:39:02 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2QCd2PK006024 for ; Wed, 26 Mar 2008 06:39:02 -0600 Date: Wed, 26 Mar 2008 07:36:31 -0500 From: Josh Boyer To: benh@kernel.crashing.org Subject: Re: [PATCH 1/2] ibm_newemac: PowerPC 440GX EMAC PHY clock workaround Message-ID: <20080326073631.108fd195@zod.rchland.ibm.com> In-Reply-To: <1206400913.7197.57.camel@pasglop> References: <20080306134105.GA31715@ru.mvista.com> <1206400913.7197.57.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 25 Mar 2008 10:21:53 +1100 Benjamin Herrenschmidt wrote: > > On Thu, 2008-03-06 at 16:41 +0300, Valentine Barshak wrote: > > The PowerPC 440GX Taishan board fails to reset EMAC3 (reset timeout error) > > if there's no link. Because of that it fails to find PHY chip. The older ibm_emac > > driver had a workaround for that: the EMAC_CLK_INTERNAL/EMAC_CLK_EXTERNAL macros, > > which toggle the Ethernet Clock Select bit in the SDR0_MFR register. This patch > > does the same for "ibm,emac-440gx" compatible chips. The workaround forces > > clock on -all- EMACs, so we select clock under global emac_phy_map_lock. > > > > Signed-off-by: Valentine Barshak > > Acked-by: Benjamin Herrenschmidt > > Just get them acked by Jeff now and they can go in via Josh tree. This never went to netdev or Jeff from what I can see. josh