* dtc: Trivial formatting fixes
@ 2008-03-26 5:21 David Gibson
2008-03-26 13:15 ` Jon Loeliger
0 siblings, 1 reply; 3+ messages in thread
From: David Gibson @ 2008-03-26 5:21 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
This patch fixes some trivial indentation and brace/bracket style
problems.
---
dtc.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
Index: dtc/dtc.c
===================================================================
--- dtc.orig/dtc.c 2008-03-26 16:18:51.000000000 +1100
+++ dtc/dtc.c 2008-03-26 16:19:12.000000000 +1100
@@ -163,8 +163,8 @@
boot_cpuid_phys = strtol(optarg, NULL, 0);
break;
case 'v':
- printf("Version: %s\n", DTC_VERSION);
- exit(0);
+ printf("Version: %s\n", DTC_VERSION);
+ exit(0);
case 'h':
default:
usage();
@@ -179,9 +179,8 @@
arg = argv[optind];
/* minsize and padsize are mutually exclusive */
- if ((minsize) && (padsize)) {
+ if (minsize && padsize)
die("Can't set both -p and -S\n");
- }
fprintf(stderr, "DTC: %s->%s on file \"%s\"\n",
inform, outform, arg);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: dtc: Trivial formatting fixes
2008-03-26 5:21 dtc: Trivial formatting fixes David Gibson
@ 2008-03-26 13:15 ` Jon Loeliger
2008-03-26 22:30 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Jon Loeliger @ 2008-03-26 13:15 UTC (permalink / raw)
To: David Gibson; +Cc: linuxppc-dev
> This patch fixes some trivial indentation and brace/bracket style
> problems.
> @@ -179,9 +179,8 @@
> arg = argv[optind];
>
> /* minsize and padsize are mutually exclusive */
> - if ((minsize) && (padsize)) {
> + if (minsize && padsize)
> die("Can't set both -p and -S\n");
> - }
I do not consider extra braces a "problem", and will
not be applying those changes. The other indentation
fixes will be applied, of course.
jdl
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: dtc: Trivial formatting fixes
2008-03-26 13:15 ` Jon Loeliger
@ 2008-03-26 22:30 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2008-03-26 22:30 UTC (permalink / raw)
To: Jon Loeliger; +Cc: linuxppc-dev
On Wed, Mar 26, 2008 at 08:15:35AM -0500, Jon Loeliger wrote:
> > This patch fixes some trivial indentation and brace/bracket style
> > problems.
>
>
> > @@ -179,9 +179,8 @@
> > arg = argv[optind];
> >
> > /* minsize and padsize are mutually exclusive */
> > - if ((minsize) && (padsize)) {
> > + if (minsize && padsize)
> > die("Can't set both -p and -S\n");
> > - }
>
>
> I do not consider extra braces a "problem", and will
> not be applying those changes. The other indentation
> fixes will be applied, of course.
Meh, whatever. Usual kernel style - which is what I originally
adopted for dtc - says no braces for one line blocks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-03-26 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-03-26 5:21 dtc: Trivial formatting fixes David Gibson
2008-03-26 13:15 ` Jon Loeliger
2008-03-26 22:30 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).