From: David Gibson <david@gibson.dropbear.id.au>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: ben@simtec.co.uk, linux-mtd@lists.infradead.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver.
Date: Thu, 27 Mar 2008 10:37:25 +1100 [thread overview]
Message-ID: <20080326233725.GB8005@localhost.localdomain> (raw)
In-Reply-To: <777c028aa41fe870542afdb4fa7d2db6@kernel.crashing.org>
On Wed, Mar 26, 2008 at 04:34:58PM +0100, Segher Boessenkool wrote:
>>>> {
>>>> + .compatible = "physmap-ram",
>>>> + .data = (void *)"map_ram",
>>>> + },
>>>> + {
>>>> + .compatible = "physmap-rom",
>>>> + .data = (void *)"map_rom",
>>>> + },
>>
>>> Why the cast? It's redundant afaics.
>>
>> To be in line with the surrounding code...
>
> I see _that_, but it's not a great argument IMNSHO. Could I trick
> you into preceding this patch with a cleanup patch for the existing
> casts?
Hrm. Much as I generally dislike redundant casts, these ones do serve
to inform the reader that the data field is not always a string, which
they might otherwise assume.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-03-26 23:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 12:44 [PATCH 1/2] [MTD] Add support for RAM & ROM mappings in the physmap_of MTD driver Laurent Pinchart
2008-03-26 14:45 ` Segher Boessenkool
2008-03-26 15:26 ` Sergei Shtylyov
2008-03-26 15:34 ` Segher Boessenkool
2008-03-26 23:37 ` David Gibson [this message]
2008-03-27 9:26 ` Laurent Pinchart
2008-04-22 20:09 ` David Woodhouse
2008-04-22 20:16 ` Sergei Shtylyov
2008-04-22 20:18 ` David Woodhouse
2008-04-23 11:12 ` Sergei Shtylyov
2008-04-25 11:53 ` Laurent Pinchart
2008-04-28 16:26 ` [PATCH 1/2] [MTD] Add support for RAM & ROMmappings " Rune Torgersen
2008-04-28 20:30 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326233725.GB8005@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=ben@simtec.co.uk \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).