From: Andrew Morton <akpm@linux-foundation.org>
To: York Sun <yorksun@freescale.com>
Cc: linux-fbdev-devel@lists.sourceforge.net, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU
Date: Thu, 27 Mar 2008 00:54:03 -0700 [thread overview]
Message-ID: <20080327005403.18d6ab07.akpm@linux-foundation.org> (raw)
In-Reply-To: <12064804383051-git-send-email-yorksun@freescale.com>
On Tue, 25 Mar 2008 16:27:17 -0500 York Sun <yorksun@freescale.com> wrote:
> +#if defined(CONFIG_NOT_COHERENT_CACHE)
> +unsigned int *coherence_data;
> +phys_addr_t *coherence_data_phy;
> +#endif
These identifiers are too general for use as global symbols. I'd suggest
renaming them to diu_coherence_data and diu_coherence_data_phy. Or make
them static - I didn't check.
I'll duck this version of the patches, as Scott's comments looked rather
substantial.
prev parent reply other threads:[~2008-03-27 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 21:27 V3 Patch - Driver for Freescale 8610 and 5121 DIU York Sun
2008-03-25 21:27 ` [PATCH 1/2 v3] " York Sun
2008-03-25 21:27 ` [PATCH 2/2 v3] Add DIU platform code for MPC8610HPCD York Sun
2008-03-25 22:19 ` [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU Scott Wood
2008-03-27 7:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327005403.18d6ab07.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=timur@freescale.com \
--cc=yorksun@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).