From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xyzzy.farnsworth.org (xyzzy.farnsworth.org [65.39.95.219]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3F7A0DE223 for ; Tue, 1 Apr 2008 02:43:11 +1000 (EST) Date: Mon, 31 Mar 2008 09:43:02 -0700 From: Dale Farnsworth To: Olof Johansson , linuxppc-dev@ozlabs.org, paulus@samba.org Message-ID: <20080331164302.GC13750@farnsworth.org> References: <20080328233954.GA29499@farnsworth.org> <20080328234900.GF30214@farnsworth.org> <20080329215942.GB27226@lixom.net> <20080330101128.GA20077@localhost.localdomain> MIME-Version: 1.0 In-Reply-To: <20080330101128.GA20077@localhost.localdomain> Subject: Re: [PATCH 6/9] [POWERPC] prpmc2800: clean up dts properties Content-Type: text/plain; charset=us-ascii List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Mar 30, 2008 at 09:11:28PM +1100, David Gibson wrote: > On Sat, Mar 29, 2008 at 04:59:42PM -0500, Olof Johansson wrote: > > On Fri, Mar 28, 2008 at 04:49:00PM -0700, Dale Farnsworth wrote: > > > From: Mark A. Greer > > > > > > Remove several unused (or software config only) properties. > > > Rename marvel node to "soc". Technically, it's not an SOC, > > > but its organization is the same as an SOC. Also, rename the > > > "block-index" property to "cell-index" to conform to current > > > practice. > > > > I see this rename as purely misleading. It isn't an soc, so it shouldn't > > be named as such. Call it system-controller or something. Pretty much > > any other name is better. :-) > > I agree. system-controller, host-bridge, north-bridge, maybe, but not > soc. With current conventions, the node name is primarily for the > benefit of human readers, so if it misleads it has failed entirely in > its purpose. I'm convinced. I'll change it to system-controller. However, I can't resist pointing out that in the existing devtrees with a "soc" node, the name is also misleading. That node doesn't refer to the SOC itself, but to the part of the SOC containing the peripherals. Whether the system is implemented on one or two chips is an implementation detail irrelevant to the drivers or device tree. -Dale