linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: Olof Johansson <olof@lixom.net>,
	linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 6/9] [POWERPC] prpmc2800: clean up dts properties
Date: Tue, 1 Apr 2008 13:22:22 +1100	[thread overview]
Message-ID: <20080401022222.GC32615@localhost.localdomain> (raw)
In-Reply-To: <20080331164302.GC13750@farnsworth.org>

On Mon, Mar 31, 2008 at 09:43:02AM -0700, Dale Farnsworth wrote:
> On Sun, Mar 30, 2008 at 09:11:28PM +1100, David Gibson wrote:
> > On Sat, Mar 29, 2008 at 04:59:42PM -0500, Olof Johansson wrote:
> > > On Fri, Mar 28, 2008 at 04:49:00PM -0700, Dale Farnsworth wrote:
> > > > From: Mark A. Greer <mgreer@mvista.com>
> > > > 
> > > > Remove several unused (or software config only) properties.
> > > > Rename marvel node to "soc".  Technically, it's not an SOC,
> > > > but its organization is the same as an SOC.  Also, rename the
> > > > "block-index" property to "cell-index" to conform to current
> > > > practice.
> > > 
> > > I see this rename as purely misleading. It isn't an soc, so it shouldn't
> > > be named as such. Call it system-controller or something. Pretty much
> > > any other name is better. :-)
> > 
> > I agree.  system-controller, host-bridge, north-bridge, maybe, but not
> > soc.  With current conventions, the node name is primarily for the
> > benefit of human readers, so if it misleads it has failed entirely in
> > its purpose.
> 
> I'm convinced.  I'll change it to system-controller.
> 
> However, I can't resist pointing out that in the existing devtrees
> with a "soc" node, the name is also misleading.  That node doesn't
> refer to the SOC itself, but to the part of the SOC containing the
> peripherals.  Whether the system is implemented on one or two chips
> is an implementation detail irrelevant to the drivers or device
> tree.

Well, quite so.  It's not even all of the peripherals on the SOC, just
the ones on Freescale SoCs that are relocatable by the IMMR register.
Which is why 4xx SoCs don't use /soc and instead have separate nodes
for the on-chip busses.

However, /soc is established now, but let's not accrete it with any
more badly named examples.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  parent reply	other threads:[~2008-04-01  2:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-28 23:39 [PATCH 0/9] powerpc: mv64x60 and prpmc2800 DTS cleanups Dale Farnsworth
2008-03-28 23:42 ` [PATCH 1/9] [POWERPC] mv64x60: change FDT compatible prefix to mrvl Dale Farnsworth
2008-03-28 23:47   ` Grant Likely
2008-03-29  0:00     ` Dale Farnsworth
2008-03-29  0:12       ` Grant Likely
2008-03-30 23:44     ` David Gibson
2008-03-31 16:56       ` Dale Farnsworth
2008-04-01  1:53         ` David Gibson
2008-03-28 23:44 ` [PATCH 2/9] [POWERPC] prpmc2800: convert DTS to v1 and add labels Dale Farnsworth
2008-03-28 23:45 ` [PATCH 3/9] [POWERPC] prpmc2800: fix frequencies in prpmc2800.dts Dale Farnsworth
2008-03-28 23:47 ` [PATCH 4/9] [POWERPC] mv64x60: Fix FDT compatible names: mv64x60 => mv64360 Dale Farnsworth
2008-03-29 21:57   ` Olof Johansson
2008-03-30 19:20     ` Segher Boessenkool
2008-03-31 16:33     ` Dale Farnsworth
2008-03-28 23:48 ` [PATCH 5/9] [POWERPC] mv64x60: remove device tree absolute path references Dale Farnsworth
2008-03-28 23:49 ` [PATCH 6/9] [POWERPC] prpmc2800: clean up dts properties Dale Farnsworth
2008-03-29 21:59   ` Olof Johansson
2008-03-30 10:11     ` David Gibson
2008-03-31 16:43       ` Dale Farnsworth
2008-04-01  1:17         ` Segher Boessenkool
2008-04-01  2:22         ` David Gibson [this message]
2008-03-28 23:50 ` [PATCH 7/9] [POWERPC] mv643xx_eth: prepare to support multiple silicon blocks Dale Farnsworth
2008-03-28 23:51 ` [PATCH 8/9] [POWERPC] Document the mv64x60 device tree bindings Dale Farnsworth
2008-03-28 23:52 ` [PATCH 9/9] [POWERPC] prpmc2800 needs a dtbImage Dale Farnsworth
2008-03-28 23:56   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080401022222.GC32615@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=dale@farnsworth.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).