From: Sam Ravnborg <sam@ravnborg.org>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: trivial@kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__'
Date: Tue, 1 Apr 2008 20:01:56 +0200 [thread overview]
Message-ID: <20080401180156.GA14553@uranus.ravnborg.org> (raw)
In-Reply-To: <47F27155.1000103@tiscali.nl>
On Tue, Apr 01, 2008 at 07:31:01PM +0200, Roel Kluin wrote:
> replace `__attribute' by `__attribute__'
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/powerpc/platforms/iseries/main_store.h b/arch/powerpc/platforms/iseries/main_store.h
> index 1a7a3f5..976b23e 100644
> --- a/arch/powerpc/platforms/iseries/main_store.h
> +++ b/arch/powerpc/platforms/iseries/main_store.h
> @@ -61,7 +61,7 @@ struct IoHriMainStoreSegment4 {
> };
>
> /* Main Store VPD for Power4 */
> -struct __attribute((packed)) IoHriMainStoreChipInfo1 {
> +struct __attribute__((packed)) IoHriMainStoreChipInfo1 {
> u32 chipMfgID;
> char chipECLevel[4];
> };
Please introduce __packed if you touch this.
See include/linux/compiler-gcc.h
This comment is relevant for all your patches.
We have __used and other similar variants.
So take a good look at include/linux/compiler* and
use the proper shortcuts where available.
Sam
next prev parent reply other threads:[~2008-04-01 18:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <47F26FF6.8070300@tiscali.nl>
2008-04-01 17:31 ` [PATCH 2/8] powerpc: replace `__attribute' by `__attribute__' Roel Kluin
2008-04-01 18:01 ` Sam Ravnborg [this message]
2008-04-01 21:36 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080401180156.GA14553@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).