linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] powerpc: Fix CPM2 SCC1 clock initialization.
@ 2008-04-02 14:46 Laurent Pinchart
  2008-04-03  6:39 ` Kumar Gala
  0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2008-04-02 14:46 UTC (permalink / raw)
  To: linuxppc-dev

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

A missing break statement in a switch caused cpm2_clk_setup() to initialize
SCC2 instead of SCC1. This patch fixes the bug.

Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
---
 arch/powerpc/sysdev/cpm2.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/sysdev/cpm2.c b/arch/powerpc/sysdev/cpm2.c
index 57ed1a4..7478e81 100644
--- a/arch/powerpc/sysdev/cpm2.c
+++ b/arch/powerpc/sysdev/cpm2.c
@@ -246,6 +246,7 @@ int cpm2_clk_setup(enum cpm_clk_target target, int clock, int mode)
 	case CPM_CLK_SCC1:
 		reg = &im_cpmux->cmx_scr;
 		shift = 24;
+		break;
 	case CPM_CLK_SCC2:
 		reg = &im_cpmux->cmx_scr;
 		shift = 16;
-- 
1.5.0


-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussée de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] powerpc: Fix CPM2 SCC1 clock initialization.
  2008-04-02 14:46 [PATCH] powerpc: Fix CPM2 SCC1 clock initialization Laurent Pinchart
@ 2008-04-03  6:39 ` Kumar Gala
  0 siblings, 0 replies; 2+ messages in thread
From: Kumar Gala @ 2008-04-03  6:39 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linuxppc-dev


On Apr 2, 2008, at 9:46 AM, Laurent Pinchart wrote:
> A missing break statement in a switch caused cpm2_clk_setup() to  
> initialize
> SCC2 instead of SCC1. This patch fixes the bug.
>
> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> ---
> arch/powerpc/sysdev/cpm2.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

applied.

However your email is malformatted.  Since it was a trivial patch I  
fixed it up by hand.

- k

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-04-03  6:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-02 14:46 [PATCH] powerpc: Fix CPM2 SCC1 clock initialization Laurent Pinchart
2008-04-03  6:39 ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).