From: Josh Boyer <jwboyer@linux.vnet.ibm.com>
To: tony@bakeyournoodle.com (Tony Breeds)
Cc: kvm-ppc-devel@lists.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Add idle wait support for 44x platforms
Date: Thu, 3 Apr 2008 20:59:27 -0500 [thread overview]
Message-ID: <20080403205927.16fc0ae7@zod.rchland.ibm.com> (raw)
In-Reply-To: <20080403230356.GJ20457@bakeyournoodle.com>
On Fri, 4 Apr 2008 10:03:56 +1100
tony@bakeyournoodle.com (Tony Breeds) wrote:
> > +int __init ppc44x_idle_init(void)
> > +{
> > + if(of_find_node_by_path("/hypervisor") != NULL) {
> ^ space
> > + /* if we find /hypervisor node is in device tree,
> > + set idle mode to wait */
> > + current_mode = 1; /* wait mode */
> > + }
>
> You don't really need the braces {} here.
They are technically not required, but I like them there none the
less because of the multi-line comment. I find it to be better style
personally.
josh
next prev parent reply other threads:[~2008-04-04 2:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 22:43 [PATCH] Add idle wait support for 44x platforms Jerone Young
2008-04-03 23:03 ` Tony Breeds
2008-04-04 1:59 ` Josh Boyer [this message]
2008-04-04 6:12 ` Jerone Young
2008-04-04 11:47 ` Josh Boyer
2008-04-08 2:17 ` Arnd Bergmann
2008-04-08 2:31 ` Josh Boyer
2008-04-08 2:41 ` Arnd Bergmann
2008-04-08 2:44 ` Josh Boyer
2008-04-03 23:13 ` [kvm-ppc-devel] " Hollis Blanchard
2008-04-04 0:17 ` Scott Wood
2008-04-04 6:15 ` Jerone Young
2008-04-04 2:00 ` Josh Boyer
2008-04-04 5:59 ` Jerone Young
2008-04-04 14:33 ` [kvm-ppc-devel] " Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080403205927.16fc0ae7@zod.rchland.ibm.com \
--to=jwboyer@linux.vnet.ibm.com \
--cc=kvm-ppc-devel@lists.sourceforge.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).