linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jens Osterkamp <jens@de.ibm.com>
Cc: maxim@de.ibm.com, linuxppc-dev@ozlabs.org,
	Paul Mackerras <paulus@samba.org>,
	cbe-oss-dev@ozlabs.org
Subject: Re: [PATCH] RTAS - adapt procfs interface
Date: Fri, 4 Apr 2008 02:12:42 +0200	[thread overview]
Message-ID: <20080404001242.GA19506@lst.de> (raw)
In-Reply-To: <200804011512.20834.jens@de.ibm.com>

On Tue, Apr 01, 2008 at 03:12:20PM +0200, Jens Osterkamp wrote:
> 
> Hi,
> 
> rtas_flash was broken since 2.6.24-rc5. This patch fixes it.
> I think this is a good bugfix candidate for 2.6.25.

NACK.  driver should not poke into the internal count member.  Just
provide your own inclusion with a new counter or set/test_bit.

  parent reply	other threads:[~2008-04-04  0:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01 13:12 [PATCH] RTAS - adapt procfs interface Jens Osterkamp
2008-04-01 16:35 ` Nathan Lynch
2008-04-01 20:04   ` Nathan Lynch
2008-04-02 11:34     ` Jens Osterkamp
2008-04-02 11:48     ` Paul Mackerras
2008-04-02 18:54       ` Nathan Lynch
2008-04-02 11:33   ` Jens Osterkamp
2008-04-04  0:12 ` Christoph Hellwig [this message]
2008-04-04  5:39   ` [Cbe-oss-dev] " Arnd Bergmann
2008-04-04  9:15     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080404001242.GA19506@lst.de \
    --to=hch@lst.de \
    --cc=cbe-oss-dev@ozlabs.org \
    --cc=jens@de.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=maxim@de.ibm.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).