From: Dale Farnsworth <dale@farnsworth.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc
Date: Mon, 7 Apr 2008 09:21:26 -0700 [thread overview]
Message-ID: <20080407162126.GC9912@farnsworth.org> (raw)
In-Reply-To: <1207573809.12481.6.camel@johannes.berg>
On Mon, Apr 07, 2008 at 03:10:09PM +0200, Johannes Berg wrote:
> > Note that I've been wondering wether we should attempt to trace all
> > those IRQ state change internally to the exception code. I've looked at
> > not doing it, which simplifies things a bit.
> >
> > Unfortunately, that will make us occasionally trace redundant
> > enable/disable (which isn't a big problem per-se, just counters).
>
> We already have a huge number of redundant enable/disable, about 40% of
> all events on both 32 and 64-bit.
Yes, but there is a big difference between the large number of actual
redundant enables and disables we now have, and introducing miscounts
of them in the measurement code. That we have so many might mean that
we shouldn't bother to count them at all, but I don't think it's an
excuse for not counting them accurately.
-Dale
next prev parent reply other threads:[~2008-04-07 16:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-04 21:39 [PATCH v2] powerpc: Add irqtrace support for 32-bit powerpc Dale Farnsworth
2008-04-04 22:07 ` Benjamin Herrenschmidt
2008-04-04 22:35 ` Dale Farnsworth
2008-04-04 22:46 ` Benjamin Herrenschmidt
2008-04-04 23:31 ` Johannes Berg
2008-04-05 5:14 ` Benjamin Herrenschmidt
2008-04-05 5:41 ` Dale Farnsworth
2008-04-07 4:49 ` Benjamin Herrenschmidt
2008-04-07 13:10 ` Johannes Berg
2008-04-07 16:21 ` Dale Farnsworth [this message]
2008-04-07 16:16 ` Dale Farnsworth
2008-04-07 17:14 ` [PATCH v3] " Dale Farnsworth
2008-04-08 16:04 ` Johannes Berg
2008-04-08 21:36 ` Johannes Berg
2008-04-18 13:19 ` Kumar Gala
2008-04-23 4:40 ` Benjamin Herrenschmidt
2008-04-23 6:33 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407162126.GC9912@farnsworth.org \
--to=dale@farnsworth.org \
--cc=johannes@sipsolutions.net \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).